New issue
Advanced search Search tips

Issue 880819 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M70: Add webAppIdentifier parameter to startEventLogging()

Project Member Reported by eladalon@chromium.org, Sep 5

Issue description

Please add appropriate OS labels. 
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Done.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8edcdc05a13b4fce25789ec82cf381203bf0bea0

commit 8edcdc05a13b4fce25789ec82cf381203bf0bea0
Author: Elad Alon <eladalon@chromium.org>
Date: Thu Sep 06 13:36:19 2018

Add webAppIdentifier parameter to startEventLogging()

Several web-apps wish to use startEventLogging. Since all logs
are currently uploaded to Crash, we need a way to distinguish
which wep-app owns which log. We'll initially use an identifier,
incorporated into the filename.

Bug: 775415,  880819 
Change-Id: I20cfda02bb679abe5ce1f816aa3f8239448f497d
Reviewed-on: https://chromium-review.googlesource.com/1201860
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588846}(cherry picked from commit be6c2cf70530b1d353374abc838df302b24befd9)
Reviewed-on: https://chromium-review.googlesource.com/1209844
Reviewed-by: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#87}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager_common.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager_common.h
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_logging_handler_host.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/media/webrtc/webrtc_logging_handler_host.h
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/resources/hangout_services/manifest.json
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/browser/resources/hangout_services/thunk.js
[modify] https://crrev.com/8edcdc05a13b4fce25789ec82cf381203bf0bea0/chrome/common/extensions/api/webrtc_logging_private.idl

Status: Fixed (was: Assigned)

Sign in to add a comment