Liftoff accidentally disabled on M-69 and M-70 |
||||||
Issue descriptionToday we figured out that Liftoff is accidentally disabled on the chromium M-69 branch. We enabled it by default in v8 in this CL: https://crrev.com/c/1118485 This had no effect on chromium however, since the chromium flag is still disabled by default, and overrides the v8 default setting. This is fixed in another CL: https://crrev.com/c/1206351 That last CL should be merged to M-70 once it landed on master. For M-69, we should enable Liftoff via finch.
,
Sep 5
+1
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2564cbca980b6fceb44b5101069c8b5b5b3667ee commit 2564cbca980b6fceb44b5101069c8b5b5b3667ee Author: Clemens Hammacher <clemensh@chromium.org> Date: Wed Sep 05 23:56:28 2018 Enable WebAssembly baseline compilation by default After the flag flip in v8 (https://crrev.com/c/1118485), this CL also changes the default of the chromium flag to enabled. Chromium always passes either "--no-wasm-tier-up" or "--wasm-tier-up" to d8, so the flag flip in v8 did not have any effect on chromium. R=titzer@chromium.org, hablich@chromium.org Bug: chromium:880790 , chromium:787421 Change-Id: I3d6b66a90ca41cb093b9bfd174ca3bfc3c35263a Reviewed-on: https://chromium-review.googlesource.com/1206351 Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589066} [modify] https://crrev.com/2564cbca980b6fceb44b5101069c8b5b5b3667ee/content/public/common/content_features.cc
,
Sep 6
Requesting backmerge to M-70, and M-69 for the respin. The current situation is: - Liftoff is finched on canary and dev since M-69 - Liftoff is enabled on M-69 beta and stable via finch - Liftoff is enabled by default on master (via CL #3) Merging back this CL to M-69 cleans things up a little. Merging back to M-70 avoids the need to enable it via finch.
,
Sep 6
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6
After discussing with hablich: Let's not merge to M-69, launching via Finch is OK.
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4579217f0aa1f7d23be0731156f5c73fa25bc06 commit c4579217f0aa1f7d23be0731156f5c73fa25bc06 Author: Clemens Hammacher <clemensh@chromium.org> Date: Fri Sep 07 14:51:34 2018 Merged: Enable WebAssembly baseline compilation by default After the flag flip in v8 (https://crrev.com/c/1118485), this CL also changes the default of the chromium flag to enabled. Chromium always passes either "--no-wasm-tier-up" or "--wasm-tier-up" to d8, so the flag flip in v8 did not have any effect on chromium. R=hablich@chromium.org, sky@chromium.org Bug: chromium:880790 , chromium:787421 Change-Id: I47b7d8d786707dbbc80f6725c7a7def0f5b199d2 Originally-reviewed-on: https://chromium-review.googlesource.com/1206351 Reviewed-on: https://chromium-review.googlesource.com/1212982 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#139} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/c4579217f0aa1f7d23be0731156f5c73fa25bc06/content/public/common/content_features.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hablich@chromium.org
, Sep 5