Regression:[RTL]Arrow key navigation is not proper on 'Select a collection' sub overlay.
Reported by
vineetha...@etouch.net,
Sep 5
|
|||||
Issue descriptionChrome version : 71.0.3543.0 (Official Build) Revision ee53a28a9a5daf56d8b73003dc12d5f8fb16665b-refs/branch-heads/3543@{#1}(32/64-bit) OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" flags and set Force UI direction to 'Right to Left' under chrome://flags. Steps to reproduce: 1. Launch chrome and open NTP. 2. Click on 'Gear' icon and click on 'Chrome backgrounds' to open 'Select a collection' overlay. 3. Select any category (Art/Landscape etc.) by clicking on the corresponding tile. 4. Observe that all the wallpapers under the selected category are displayed. 5. Press 'down arrow' button on keyboard to get focus on one of the wallpaper. 6. Now press left arrow key and observe. Actual Result :On pressing left arrow key, focus navigates to the option present at the right. Expected Result:On pressing left arrow key, focus should travel to the option present to the left instead of right. This is a regression issue broken in ‘M-70’ and below is bisect info. Good build: 70.0.3503.0 Bad build : 70.0.3504.0 You are probably looking for a change made after 578169 (known good), but no later than 578170 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7637ae87b8e8ef651fdcd15e8ace6da78053e6b0..b315c20043e0a5ad29ed29ce7d47aaba043b8204 Suspect: https://chromium.googlesource.com/chromium/src/+/b315c20043e0a5ad29ed29ce7d47aaba043b8204 @kmilka: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: 1) On Mac OS, additional flag of 'Enable RTL' has to be enabled under chrome://flags. 2) Issue is also reproducible after changing chrome language to any rtl language e.g: Arabic in Windows OS. Thank You
,
Sep 11
,
Sep 11
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d881ca3889d70760b71fb99d90bf37613673ff4f commit d881ca3889d70760b71fb99d90bf37613673ff4f Author: Kyle Milka <kmilka@chromium.org> Date: Wed Sep 12 02:10:47 2018 [NTP] Fix RTL arrow key navigation Previously arrow key navigation was fixed for the collection selection dialog in RTL mode, but not for the image selection dialog. Bug: 880764 Change-Id: I96f4f007d6f8f8ecda7a5f72e8353e75a6391211 Reviewed-on: https://chromium-review.googlesource.com/1220767 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#590573} [modify] https://crrev.com/d881ca3889d70760b71fb99d90bf37613673ff4f/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Sep 12
,
Sep 14
Update: Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS using build #71.0.3551.3 and issue is fixed. Kindly refer attached screen cast. Thank You.. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ramyan@chromium.org
, Sep 10