CCA UI Refresh: thumbnail doesn't match the pictures after clicking thumbnail icon |
||||
Issue descriptionCCA version: 5.1.1 What steps will reproduce the problem? (1) take several pictures quickly (2) click thumbnail to see latest picture in gallery app (3) delete the latest picture in gallery app (4) close gallery app (5) click thumbnail again (6) thumbnail doesn't change. but the picture in gallery app changes to second latest picture What is the expected result? thumbnail change to second latest picture What happens instead? thumbnail doesn't change
,
Sep 5
Re #1, I have seen on Henry's device that after (5) and (6), and go back to CCA, the thumbnail still was not updated.
,
Sep 5
Thanks. shenghao@, would you please help to check by dev-tools: https://chromium.googlesource.com/apps/camera/+/master/src/js/views/camera/gallerybutton.js#62 https://chromium.googlesource.com/apps/camera/+/master/src/js/views/camera/gallerybutton.js#81 https://chromium.googlesource.com/apps/camera/+/master/src/js/views/camera/gallerybutton.js#90 After deleting the last picture, all these above three lines should point to the second last picture. But it doesn't work now. Thanks much.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/e5e2fd60bc0923a726402d917427c367092de563 commit e5e2fd60bc0923a726402d917427c367092de563 Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 09:19:33 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/e5e2fd60bc0923a726402d917427c367092de563/src/js/views/camera/gallerybutton.js
,
Sep 7
Thanks very much for henryhsu@'s and shenghao@'s help so that I found regression was from https://chromium.googlesource.com/apps/camera/+/e6e41b07e6a84b06fa816b383775099cfcee5648. Thanks.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/2b37673a457f6ff9c18c64086d6e5b9b9725f0bf commit 2b37673a457f6ff9c18c64086d6e5b9b9725f0bf Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 12:02:54 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> (cherry picked from commit e5e2fd60bc0923a726402d917427c367092de563) Reviewed-on: https://chromium-review.googlesource.com/1212668 [modify] https://crrev.com/2b37673a457f6ff9c18c64086d6e5b9b9725f0bf/src/js/views/camera/gallerybutton.js
,
Sep 7
,
Sep 25
Verified on CCA 5.2.1
,
Sep 27
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5e2fd60bc0923a726402d917427c367092de563 commit e5e2fd60bc0923a726402d917427c367092de563 Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 09:19:33 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/e5e2fd60bc0923a726402d917427c367092de563/src/js/views/camera/gallerybutton.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by y...@chromium.org
, Sep 5