New issue
Advanced search Search tips

Issue 880745 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Audio-Service


Sign in to add a comment

Audio service: InputController calls into InputStream in the context of InputStream constructor.

Project Member Reported by olka@chromium.org, Sep 5

Issue description

InputStream::InputStream() -> InputController::Create() (receives InputController*  as EventHander) -> InputController::DoCreate() -> calls back into the handler.

There is a bit of protection there though to not delete InputStream in its own constructor:
https://cs.chromium.org/chromium/src/services/audio/input_stream.cc?type=cs&g=0&l=230
 
Labels: -Pri-1 Pri-2
For this one, we could make InputController implement the mojom::InputStream interface to simplify a bit, and then use the two-phase construction of InputController to simplify this awkwardness (with same modifications to output for simplicity).

Sign in to add a comment