CCA doesn't show thumbnail after migration |
||||
Issue descriptionCCA version: 5.1.1 What steps will reproduce the problem? (1) install old camera.crx and take some pictures (2) install new camera.crx and see migration dialog (3) do migration enter CCA preview (4) thumbnail icon is empty What is the expected result? thumbnail icon should be latest migrated picture What happens instead? empty thumbnail icon Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Sep 5
Hmm...not always reproduce
,
Sep 5
Henry, could you attach the old/new crx you used?
,
Sep 6
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/e5e2fd60bc0923a726402d917427c367092de563 commit e5e2fd60bc0923a726402d917427c367092de563 Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 09:19:33 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/e5e2fd60bc0923a726402d917427c367092de563/src/js/views/camera/gallerybutton.js
,
Sep 7
Thanks very much for henryhsu@'s and shenghao@'s help so that I found regression was from https://chromium.googlesource.com/apps/camera/+/e6e41b07e6a84b06fa816b383775099cfcee5648. Thanks.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/2b37673a457f6ff9c18c64086d6e5b9b9725f0bf commit 2b37673a457f6ff9c18c64086d6e5b9b9725f0bf Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 12:02:54 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> (cherry picked from commit e5e2fd60bc0923a726402d917427c367092de563) Reviewed-on: https://chromium-review.googlesource.com/1212668 [modify] https://crrev.com/2b37673a457f6ff9c18c64086d6e5b9b9725f0bf/src/js/views/camera/gallerybutton.js
,
Sep 7
,
Sep 25
Verified on CCA 5.2.1
,
Sep 27
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5e2fd60bc0923a726402d917427c367092de563 commit e5e2fd60bc0923a726402d917427c367092de563 Author: Yuli Huang <yuli@chromium.org> Date: Fri Sep 07 09:19:33 2018 Add quotes to properly handle filenames. BUG= chromium:880744 , chromium:880752 , TEST=Tested by filenames with ' (1)' and ' (2)'. Change-Id: Ia5a1b44b2deb1e3240c4183d15d3d358d84bc4f4 Reviewed-on: https://chromium-review.googlesource.com/1212627 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/e5e2fd60bc0923a726402d917427c367092de563/src/js/views/camera/gallerybutton.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by henryhsu@chromium.org
, Sep 5Labels: M-70