New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880737 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Improper Alignment of 'Remove from list'(x)icon and 'Downloaded in incognito' icon is seen under chrome://downloads

Reported by shruti.j...@etouch.net, Sep 5

Issue description

Chrome version : 71.0.3543.0 (Official Build) ee53a28a9a5daf56d8b73003dc12d5f8fb16665b-refs/branch-heads/3543@{#1}(32/64 bit)
OS: Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)

Test URL:https://permission.site

Steps to reproduce:
1.Launch chrome ,open Incognito window and Navigate to above URL.
2.Click on 'Auto download' button and click on 'Allow' so that files get downloaded .
3.Navigate to chrome://downloads and observe alignment of 'Remove from list'(x)icon and 'Downloaded in incognito' icon.

Actual Result: Improper Alignment of 'Remove from list'(x)icon and 'Downloaded in incognito' icon is seen.
Expected Result:Proper  Alignment of 'Remove from list'(x)icon and 'Downloaded in incognito' icon should be seen.

This is a regression issue, broken in 'M-70' and below is the per-revision info:

Good Build:70.0.3501.0(Revision:577394)
Bad Build:70.0.3503.0(Revision:578159)

You are probably looking for a change made after 577748 (known good), but no later than 577749 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/0dc78f92395b6c291a2a905f687ec77b914638ef..f2a892ed06acbe22c04d10c91ccd4101c2bb67b6

Suspect: https://chromium.googlesource.com/chromium/src/+/f2a892ed06acbe22c04d10c91ccd4101c2bb67b6

@Scott Chen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast 
Thank You.


 
Expected_Result.mp4
524 KB View Download
Expected Result.png
52.8 KB View Download
Actual.png
53.2 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95853957a03c3e4d8a407b1f001bfbbba185053e

commit 95853957a03c3e4d8a407b1f001bfbbba185053e
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Sep 11 23:07:03 2018

Downloads: fix incognito icon alignment

Bug:  880737 
Change-Id: I2c455762066d424a3cde4e91dc70eacfc1b4fb7c
Reviewed-on: https://chromium-review.googlesource.com/1217033
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590519}
[modify] https://crrev.com/95853957a03c3e4d8a407b1f001bfbbba185053e/chrome/browser/resources/md_downloads/item.html

Labels: TE-Verified-M71 TE-Verified-71.0.3551.3
Update:

Rechecked the above issue on Win (7,8,8.1,10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux (14.04 LTS) using latest dev version #71.0.3551.3 and the issue is found FIXED.
Hence, adding respective labels.

Please refer the attached screen-cast.

Thank You..!!

Fixed Video.mov
3.1 MB View Download
Status: Fixed (was: Started)

Sign in to add a comment