Enable system AEC for Chrome |
||||||||
Issue descriptionPer offline discussion, WebRTC team suggest to enable the system AEC feature for all CrOS boards, on A70. We're good to do this because the feature is behind a origin trial control in browser. Which means there's going to be limited web apps using this feature. And we can get some early feedback and bug fix in M70.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03333c5c8ec263abca405601de211a217cad6b22 commit 03333c5c8ec263abca405601de211a217cad6b22 Author: Hsin-Yu Chao <hychao@google.com> Date: Tue Oct 02 07:00:26 2018 Set system AEC supported to true for Chrome OS Web app selecting echo canceller type to system AEC is behind an experimental origin trial. Removing the flag report from Chrome OS system, so it's easier to control testing for this feature. Bug: 880708 Change-Id: I10f981d2bd27e04a372d12644eae2903521c7ea1 Reviewed-on: https://chromium-review.googlesource.com/1248063 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595745} [modify] https://crrev.com/03333c5c8ec263abca405601de211a217cad6b22/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/03333c5c8ec263abca405601de211a217cad6b22/chromeos/audio/cras_audio_handler.h
,
Oct 2
Request merge to M70. This is to flip the system_aec_supportted flag on Chrome OS, so that Web applications can try out the experimental support for native AEC, as listed in https://github.com/GoogleChrome/OriginTrials/blob/gh-pages/available-trials.md Abdul, can you help with the approval?
,
Oct 2
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2
This is in the chromeos/audio directory of chromium project. Not sure which TPM should I get merge approval from. Adding geohsu@ as well.
,
Oct 2
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe050665f7cab9ed4e254f6b6e060056a07293d6 commit fe050665f7cab9ed4e254f6b6e060056a07293d6 Author: Hsin-Yu Chao <hychao@google.com> Date: Thu Oct 04 06:16:47 2018 Set system AEC supported to true for Chrome OS Web app selecting echo canceller type to system AEC is behind an experimental origin trial. Removing the flag report from Chrome OS system, so it's easier to control testing for this feature. TBR=hychao@google.com (cherry picked from commit 03333c5c8ec263abca405601de211a217cad6b22) Bug: 880708 Change-Id: I10f981d2bd27e04a372d12644eae2903521c7ea1 Reviewed-on: https://chromium-review.googlesource.com/1248063 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595745} Reviewed-on: https://chromium-review.googlesource.com/c/1257490 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#847} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/fe050665f7cab9ed4e254f6b6e060056a07293d6/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/fe050665f7cab9ed4e254f6b6e060056a07293d6/chromeos/audio/cras_audio_handler.h
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe050665f7cab9ed4e254f6b6e060056a07293d6 Commit: fe050665f7cab9ed4e254f6b6e060056a07293d6 Author: hychao@google.com Commiter: wuchengli@chromium.org Date: 2018-10-04 06:16:47 +0000 UTC Set system AEC supported to true for Chrome OS Web app selecting echo canceller type to system AEC is behind an experimental origin trial. Removing the flag report from Chrome OS system, so it's easier to control testing for this feature. TBR=hychao@google.com (cherry picked from commit 03333c5c8ec263abca405601de211a217cad6b22) Bug: 880708 Change-Id: I10f981d2bd27e04a372d12644eae2903521c7ea1 Reviewed-on: https://chromium-review.googlesource.com/1248063 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#595745} Reviewed-on: https://chromium-review.googlesource.com/c/1257490 Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#847} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 17
Landed in 70.0.3538.53 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hychao@chromium.org
, Sep 5