New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 880698 link

Starred by 1 user
Status: WontFix
Owner:
█ apaci...@chromium.org
no longer active
Closed: Sep 19
Cc:
yukishiino@chromium.org
ifratric@google.com
kkaluri@chromium.org
mlamouri@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: false. DOMExeption should not be thrown in html_media_element.h

Project Member Reported by ClusterFuzz, Sep 5 
Detailed report: https://clusterfuzz.com/testcase?key=5736879350349824

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false. DOMExeption should not be thrown in html_media_element.h
  blink::NonThrowableExceptionState::ThrowDOMException
  blink::HTMLMediaElement::setPlaybackRate
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=548447:548451

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5736879350349824

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
Project Member

Comment 1 by ClusterFuzz, Sep 5

Components: Blink>Bindings Blink>Media
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by kkaluri@chromium.org, Sep 5

Cc: kkaluri@chromium.org
Labels: M-69 Test-Predator-Wrong
Owner: yukishiino@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "exception_state.cc" assigning to the concern owner.

Suspecting Commit : https://chromium.googlesource.com/chromium/src/+/3ccf4b39bb83a2b0564cbef8e83e4db51386f9c7

yukishiino@ -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 3 by ClusterFuzz, Sep 8

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 5736879350349824 appears to be flaky, updating reproducibility label.

Comment 4 by yukishiino@chromium.org, Sep 10

Cc: yukishiino@chromium.org
Labels: -Pri-1 Pri-2
Owner: mlamouri@chromium.org
Assign the issue to mlamouri@, an owner of Blink>Media.

HTMLMediaElement::setPlaybackRate is expected to throw a DOMException, but ASSERT_NO_EXCEPTION default argument is used incorrectly.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/html/media/html_media_element.h?rcl=d07754fc03da97240e0408a9258db85057650203&l=187

In general, ASSERT_NO_EXCEPTION shouldn't be (ab)used widely in production code as it's expected for user agents to propagate an exception to web author's try-catch block.  This specific use case seems misuse (or abuse) of ASSERT_NO_EXCEPTION.  The best fix would be to remove the default argument.  setPlaybackRate has only two call sites.

Comment 5 by mlamouri@chromium.org, Sep 11

Cc: mlamouri@chromium.org
Owner: apaci...@chromium.org
Assigning to apacible@ as I believe she is the author of this change and I do not have cycles for this too :(
Project Member

Comment 6 by ClusterFuzz, Sep 19

Status: WontFix (was: Assigned)
ClusterFuzz testcase 5736879350349824 is flaky and no longer crashes, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
►

Sign in to add a comment