New issue
Advanced search Search tips

Issue 880683 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 811921
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Keyboard shortcuts broken for Japanese keyboards in Chrome 69

Reported by richardk...@gmail.com, Sep 5

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Steps to reproduce the problem:
1. Get a Macbook with a Japanese keyboard
2. Press ⌘+shift+{
3. Switches one tab to the right
2. Press ⌘+shift+@
3. Switches one tab to the left
2. Press ⌘+shift+}
3. Does nothing

What is the expected behavior?
⌘+shift+{ goes left
⌘+shift+} goes right
⌘+shift+@ goes ... nowhere I think?

What went wrong?
Can't switch tabs properly

Did this work before? Yes 68

Chrome version: 69.0.3497.81  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Doesn't happen in Canary
 
Cc: pbomm...@chromium.org erikc...@chromium.org ellyjo...@chromium.org js...@chromium.org
Labels: Needs-Triage-M69
Additional information: ⌘+] and ⌘+[ work as expected, so it appears to be something to do with the shift key being down
Cc: viswa.karala@chromium.org
Labels: Needs-Feedback Triaged-ET
Unable to reproduce the issue on chrome reported version# 69.0.3497.81 using Mac 10.12.6 with steps mentioned below:
1) Launched chrome reported version and changed keyboard language to Japanese
2) Pressed ⌘+shift+{, focus changed to left tab
3) Pressed ⌘+shift+}, focus changed to right tab
4) Pressed ⌘+shift+@, nothing happens

@Reporter: Please find the attached screencast for your reference and let us know if we missed anything in reproducing the issue, provide your feedback on it which help in further triaging it. Try to test this issue by creating new person with no apps and extensions and let us know if the issue still persists.

Thanks!
880683.mp4
1.4 MB View Download
Is your physical keyboard JIS? As in the key to the right of "P" is "@" and the one to the right of that is "["
I also already tried a new person on two different machines and got the same result.
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 5

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I'm facing the same issue on the same environment as the original reporter. I attach a screenshot. Please note the key left below displayed by Keycastr. Also, shift+@ is equals to ` on Japanese keyboard.

I am so sorry I failed to attach a gif file. I attach mp4 screenshot. Please confirm.
tab.mp4
656 KB View Download
Labels: Target-71 M-71
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
mac triage: over to erikchen@
Labels: Needs-Feedback
I unfortunately do not have a japanese keyboard. A similar issue has already been fixed on Canary -- can you check to see if the issue reproduces on Canary?

Also, can you check if <ctr> + <tab> works correctly to move between tabs? 

https://bugs.chromium.org/p/chromium/issues/detail?id=880880#c10
Ctrl+tab works. Does not reproduce in Canary.

The other thread says there is nothing to do but is there any chance of getting a patch release? All Mac users in Japan are going to have to get used to this new US-style shortcut only to have it switched back a few weeks later.
Mergedinto: 811921
Status: Duplicate (was: Assigned)
Thanks for confirming that this works in Canary.

Unfortunately, the fix is a bit trickier than I feel comfortable merging back to M69 [which wouldn't see a respin for weeks, anyways]. This will remain broken until M70. :(
OK thanks for the response. Although I don't speak for all Japanese users this is kind of a bummer. I hope there's a test or something in the pipeline to ensure a similar issue doesn't come up again in the future.
When I fixed this bug I added tests:
https://chromium-review.googlesource.com/c/chromium/src/+/1167466/8/chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm#283

Unfortunately, I don't have a japanese keyboard so I won't be able to add tests specifically for the Japanese test case, but hopefully the dvorak-qwerty tests should capture the same problem.

Sign in to add a comment