Clean up experiment flags for ChromeOS IME component |
|||
Issue descriptionWe have some unused experiments in the IME component, some are launched and some are abandoned. We should cleanup these experiments in both IME extension and Chrome to simplify the code/logic.
,
Sep 5
,
Sep 7
Now we have 12 flags in use. 0: "floatingkeyboard" 1: "gesturetyping" 2: "gestureediting" 3: "experimental" 4: "fullscreenhandwriting" 5: "virtualkeyboardmdui" 6: "imeservice" 7: "voiceinput" 8: "autocomplete" 9: "autocorrect" 10: "spellcheck" 11: "handwriting" Please help me check which are not used anymore.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3aa44cb590bb6c319afce3edbac22fc860b018db commit 3aa44cb590bb6c319afce3edbac22fc860b018db Author: Leo Zhang <googleo@chromium.org> Date: Mon Sep 10 08:19:22 2018 Keyboard flags cleanup. Remove unused keyboard flag kEnableExperimentalInputViewFeatures which is faulty now. Bug: 880659 Change-Id: Ia4bb8ec3cfd4f38393fe9e6f270563fc7c313245 Reviewed-on: https://chromium-review.googlesource.com/1212427 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589854} [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/chrome/browser/about_flags.cc [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/chrome/browser/flag_descriptions.h [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/ui/keyboard/keyboard_switches.cc [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/ui/keyboard/keyboard_switches.h [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/ui/keyboard/keyboard_util.cc [modify] https://crrev.com/3aa44cb590bb6c319afce3edbac22fc860b018db/ui/keyboard/keyboard_util.h
,
Sep 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by goog...@chromium.org
, Sep 5