CCA - Accessibility - Camera toggle label difficult to understand |
||||
Issue descriptionChrome Version: 70.0.3532.8 CCA 5.2 What steps will reproduce the problem? (1) Launch CCA (2) Turn on ChromeVox (3) Select toggle camera button What is the expected result? Message would indicate which camera the button would enable "Switch to rear camera" "Switch to front camera" What happens instead? Button just says "Toggle camera" so user does not know which camera will be activated
,
Oct 23
,
Oct 31
Currently CCA keeps a list of available camera devices, and the toggle-camera button switches to the next 'available' camera. However, we don't know which camera will be up next until the camera is successfully switched over. e.g. if it fails to open the next camera at the end (occupied by other apps, etc), CCA will loop to another device on the list. Showing a facing-message beforehand may end up opening a camera with the different facing from the facing-message indicated. To improve its accessibility, we have changed the toggle-camera's message to "Switch to next camera" and made the successfully connected camera (e.g. front camera, back camera, or external cameras) being announced after switching over.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/71b390e97d885eb9b2da10828536a363d355dfa0 commit 71b390e97d885eb9b2da10828536a363d355dfa0 Author: Yuli Huang <yuli@chromium.org> Date: Wed Oct 31 09:43:42 2018 Improve accessibility for switching camera devices. Announce the active camera after switching camera devices. BUG= chromium:880641 TEST=Tested by clicking switch-device button. Change-Id: I6f9076b6a31540296bd2ebc9bb1a65655aac719e Reviewed-on: https://chromium-review.googlesource.com/c/1307713 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera.js [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/_locales/en/messages.json [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera/layout.js [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera/options.js
,
Oct 31
This change makes sense to me. Thanks for thinking through the edge cases.
,
Nov 1
,
Nov 1
Still reproducible on Nocturne DVT main4 with build 11151.19.0, 71.0.3578.31 (beta) channel
,
Nov 2
It's fixed in 5.2.6; we'll soon update the canary for verifying these fixes. Thanks much.
,
Nov 5
CCA 5.2.6 is ready for testing. Please verify the fix with the updated canary. Thanks.
,
Nov 8
Verified on Nocturne DVT main1, Nautilus, Soroka with 11151.23.0, 71.0.3578.39 (beta) channel with CCA 5.2.6 (works) - Toggle-camera's message to "Switch to next camera" and made the successfully connected camera (e.g. front camera, back camera, or external cameras) being announced after switching over.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b390e97d885eb9b2da10828536a363d355dfa0 commit 71b390e97d885eb9b2da10828536a363d355dfa0 Author: Yuli Huang <yuli@chromium.org> Date: Wed Oct 31 09:43:42 2018 Improve accessibility for switching camera devices. Announce the active camera after switching camera devices. BUG= chromium:880641 TEST=Tested by clicking switch-device button. Change-Id: I6f9076b6a31540296bd2ebc9bb1a65655aac719e Reviewed-on: https://chromium-review.googlesource.com/c/1307713 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/_locales/en/messages.json [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera.js [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera/layout.js [modify] https://crrev.com/71b390e97d885eb9b2da10828536a363d355dfa0/src/js/views/camera/options.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by y...@chromium.org
, Sep 6Labels: M-70