New issue
Advanced search Search tips

Issue 880636 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CCA - Accessibility - "Stop taking photo" message heard when taking photos with ChromeVox enabled

Project Member Reported by tclaiborne@chromium.org, Sep 4

Issue description

Chrome Version: 70.0.3532.8 CCA 5.2

What steps will reproduce the problem?
(1) Launch CCA
(2) Turn on ChromeVox
(3) Take a photo

What is the expected result? "Taking photo" message or "Photo taken"

What happens instead? Button changes function from take photo to stop taking photo, and "stop taking photo" is read out.

We might want to remove the "stop taking photo" functionality except in the case of using a timer. It's pretty difficult to stop taking a photo before it's actually taken and also not an expected user interaction.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/de07f04a7762bf8831341d6a8cbbce6356bc2ff8

commit de07f04a7762bf8831341d6a8cbbce6356bc2ff8
Author: Yuli Huang <yuli@chromium.org>
Date: Fri Sep 07 13:45:35 2018

Fix shutter label and revise end-take handling.

BUG= chromium:880636 ,chromium:878738
TEST=Tested by taking photo or recording with timer on/off.

Change-Id: Ie501c2dbecd2473b6b6ed0f6447ea2c029d8fb21
Reviewed-on: https://chromium-review.googlesource.com/1212625
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/de07f04a7762bf8831341d6a8cbbce6356bc2ff8/src/js/views/camera.js

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7

Labels: merge-merged-version-5.2
The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/0704a43fed3f5790f0fb412d65b99cadb1f5279c

commit 0704a43fed3f5790f0fb412d65b99cadb1f5279c
Author: Yuli Huang <yuli@chromium.org>
Date: Fri Sep 07 13:55:09 2018

Fix shutter label and revise end-take handling.

BUG= chromium:880636 ,chromium:878738
TEST=Tested by taking photo or recording with timer on/off.

Change-Id: Ie501c2dbecd2473b6b6ed0f6447ea2c029d8fb21
Reviewed-on: https://chromium-review.googlesource.com/1212625
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>
(cherry picked from commit de07f04a7762bf8831341d6a8cbbce6356bc2ff8)
Reviewed-on: https://chromium-review.googlesource.com/1213482

[modify] https://crrev.com/0704a43fed3f5790f0fb412d65b99cadb1f5279c/src/js/views/camera.js

Verified on CCA 5.2.1
Status: Verified (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de07f04a7762bf8831341d6a8cbbce6356bc2ff8

commit de07f04a7762bf8831341d6a8cbbce6356bc2ff8
Author: Yuli Huang <yuli@chromium.org>
Date: Fri Sep 07 13:45:35 2018

Fix shutter label and revise end-take handling.

BUG= chromium:880636 ,chromium:878738
TEST=Tested by taking photo or recording with timer on/off.

Change-Id: Ie501c2dbecd2473b6b6ed0f6447ea2c029d8fb21
Reviewed-on: https://chromium-review.googlesource.com/1212625
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/de07f04a7762bf8831341d6a8cbbce6356bc2ff8/src/js/views/camera.js

Sign in to add a comment