CCA Tab ordering is difficult to follow in full screen |
||||
Issue descriptionChrome Version: 70.0.3532.8 CCA 5.2 What steps will reproduce the problem? (1) Open CCA in full screen, not full screen (2) Tab through options What is the expected result? Tab would follow a visual order of elements What happens instead? Tab order is: shutter button, video recording button, gallery, grid options, timer options, shutter button, which does not follow the UI direction. Root cause The placement of the UI elements is different when CCA is windowed vs. maximized. The tab ordering makes sense in full screen mode, but looks wrong in windowed mode. Fix recommended by accessibility is to change the tab ordering when are in full screen mode to match the relative positions of UI elements. Recommended order 1. Shutter button 2. Video recording button 3. Grid options 4. Timer options 5. Gallery
,
Sep 5
Talked with Yuli. We agree that the tab flow needs to be fixed. But since we have done so many customization of tab flow in CCA, changing it at this stage is too risky. Yuli will revamp the whole tab flow control in CCA in next release.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/f5c0acf831424afd746d12d6aab5513fe1002ed4 commit f5c0acf831424afd746d12d6aab5513fe1002ed4 Author: Yuli Huang <yuli@chromium.org> Date: Tue Oct 23 07:59:18 2018 Fix Tab order by updating DOM order. BUG= chromium:880626 TEST=Tested by tabbing buttons in fullscreen/windowed views. Change-Id: I84b1a4f8684f2a3899de5d2c2f1392376e66ec62 Reviewed-on: https://chromium-review.googlesource.com/c/1292696 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/f5c0acf831424afd746d12d6aab5513fe1002ed4/src/views/main.html
,
Oct 23
To reduce implementation complexity, we make tab order the same in both fullscreen/windowed mode: switch-to-take-photo* -> shutter -> switch-to-record-video* -> mic* -> (settings) -> mirror* -> grid -> timer -> switch-devices* -> gallery-button
,
Oct 25
,
Oct 25
Tested with build 11151.11.0, 71.0.3578.21 (dev) (CCA 5.2.5) CCA Tab order: Eve (Desktop) (only 1 Front facing camera): Full/Window (Photo mode) 1. Shutter button 2. Camera Photo button 3. Gallery icon (if there are files available) 4. Grid options 5. Timer options (Video recording mode) 1. Gallery icon (if there are files available) 2. Grid options 3. Timer options 4. Microphone 5. Camera Photo button 6. Video recording button Soroka / Nocturne (Tablet) and Robo360 Clamshell (Front/Back facing camera: Full/Window) (Photo mode) 1. Shutter button 2. Camera Photo button 3. Toggle switch camera 4. Gallery icon (if there are files available) 5. Grid options 6. Timer options (Video recording mode) 1. Camera Photo button 2. Video recording button 3. Toggle switch camera 4. Gallery icon (if there are files available) 5. Grid options 6. Timer options 7. Microphone
,
Oct 26
shenghao@ will update CCA canary next week to verify the fix. Thanks.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5c0acf831424afd746d12d6aab5513fe1002ed4 commit f5c0acf831424afd746d12d6aab5513fe1002ed4 Author: Yuli Huang <yuli@chromium.org> Date: Tue Oct 23 07:59:18 2018 Fix Tab order by updating DOM order. BUG= chromium:880626 TEST=Tested by tabbing buttons in fullscreen/windowed views. Change-Id: I84b1a4f8684f2a3899de5d2c2f1392376e66ec62 Reviewed-on: https://chromium-review.googlesource.com/c/1292696 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/f5c0acf831424afd746d12d6aab5513fe1002ed4/src/views/main.html
,
Jan 15
|
||||
►
Sign in to add a comment |
||||
Comment 1 by shenghao@chromium.org
, Sep 5