New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880611 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

TopControlsSlideControllerTest.TestClosingATab is flaky

Project Member Reported by mukai@chromium.org, Sep 4

Issue description

browser_tests on linux-chromeos-dbg bot is failing on TopControlsSlideControllerTest.TestClosingATab

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg

Seems stuck on TabNonEmptyPaintWaiter::Wait().

Test log copied from https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936283666089758784/+/steps/browser_tests/0/stdout

[ RUN      ] TopControlsSlideControllerTest.TestClosingATab
[19429:19429:0904/145429.055348:WARNING:chrome_browser_main_chromeos.cc(580)] Running as stub user with profile dir: test-user
[19429:19429:0904/145429.782822:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[19429:19429:0904/145429.782955:WARNING:remote_commands_service.cc(40)] Client is not registered.
[19429:19429:0904/145429.783600:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[19429:19429:0904/145429.783759:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[19429:19429:0904/145429.783895:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[19429:19429:0904/145429.784054:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[19429:19429:0904/145430.616054:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616122:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616162:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616567:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616612:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616641:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616746:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616777:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.616815:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.617158:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.617196:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145430.617224:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type.
[19429:19429:0904/145431.137845:ERROR:content_gpu_interface_provider.cc(83)] Not implemented reached in virtual void ash::ContentGpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[19429:19429:0904/145431.272430:WARNING:shelf_button.cc(381)] An icon of size 32x32is being scaled up and will look blurry.
[19429:19584:0904/145431.867588:WARNING:simple_synchronous_entry.cc(1252)] Could not open platform files for entry.
[19429:19774:0904/145432.364950:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7ff83da4674d base::debug::StackTrace::StackTrace()
#1 0x7ff83d75d26c base::debug::StackTrace::StackTrace()
#2 0x000007fe5ce4 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7ff8109f4cb0 <unknown>
#4 0x7ff810abc6d3 epoll_wait
#5 0x7ff83daf0871 epoll_dispatch
#6 0x7ff83dae3f25 event_base_loop
#7 0x7ff83da93525 base::MessagePumpLibevent::Run()
#8 0x7ff83d7ec1be base::MessageLoop::Run()
#9 0x7ff83d893572 base::RunLoop::Run()
#10 0x000002f4c439 (anonymous namespace)::TabNonEmptyPaintWaiter::Wait()
#11 0x000002f4e848 (anonymous namespace)::TopControlsSlideControllerTest_TestClosingATab_Test::RunTestOnMainThread()
#12 0x000007fe450e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#13 0x000000ae2d7d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#14 0x000000ae2cc4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#15 0x000007fe7095 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#16 0x000007fe6fcc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#17 0x000000ad33ad _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#18 0x000006e6b7b3 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#19 0x000006e6998e ChromeBrowserMainParts::PreMainMessageLoopRun()
#20 0x0000036f3aae chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#21 0x7ff8337b290c content::BrowserMainLoop::PreMainMessageLoopRun()
#22 0x7ff8324eaafd _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
#23 0x7ff8324eaa44 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
#24 0x7ff8337b85d5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#25 0x7ff8337b850c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#26 0x7ff8323fa5bd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv



This test looks new -- assigning afakhry who added this test.
cc: chrome-on-chromeos gardener and chrome sheriffs.
 
Status: Started (was: Assigned)
Labels: -Pri-3 Pri-2
Status: Fixed (was: Started)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1205670 landed.
Cc: tasak@google.com
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a3df34ec2abb272d570a7179deb0fbfc256fe7

commit 85a3df34ec2abb272d570a7179deb0fbfc256fe7
Author: Ahmed Fakhry <afakhry@google.com>
Date: Wed Sep 05 00:05:09 2018

Fix a flaky top-chrome slide test

The webcontents may have already completed the first
visually non-empty paint before we wait for this event.

This CL fixes tests being flaky because of this issue.

BUG=867063,  880611 

Change-Id: Ife7c598afaa31b51466b28f9476d0045b89c8a7f
Reviewed-on: https://chromium-review.googlesource.com/1205670
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588708}
[modify] https://crrev.com/85a3df34ec2abb272d570a7179deb0fbfc256fe7/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc

Sign in to add a comment