New issue
Advanced search Search tips

Issue 880605 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 6
Cc:
omrilio@chromium.org
weidongg@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Backdrop is blocking everything on swipe up.

Project Member Reported by sammiequon@chromium.org, Sep 4 
The swipe up used to show fine because a bug was causing the backdrop to be hidden. That bug has since been fixed; we need to also slide the backdrop offscreen (and onscreen when swiping down). This should also fix the issue with non-resizable windows not working.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1245672eaeb46c3fe721a0c062c7c5a8378f2ad1

commit 1245672eaeb46c3fe721a0c062c7c5a8378f2ad1
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Sep 05 17:06:42 2018

applist: Slide backdrop in or out on swipe up or down.

The backdrop now moves with the window when swiping up or down to use
home launcher gestures. This also allows non resizable windows to be
swiped up or down now.

Test: manual
Bug:  880605 
Change-Id: I020f21fc04f95da55cd2c897841ade0b105d66ed
Reviewed-on: https://chromium-review.googlesource.com/1205593
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588899}
[modify] https://crrev.com/1245672eaeb46c3fe721a0c062c7c5a8378f2ad1/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/1245672eaeb46c3fe721a0c062c7c5a8378f2ad1/ash/app_list/home_launcher_gesture_handler.h
[modify] https://crrev.com/1245672eaeb46c3fe721a0c062c7c5a8378f2ad1/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/1245672eaeb46c3fe721a0c062c7c5a8378f2ad1/ash/wm/workspace/workspace_layout_manager.h

Comment 2 by sammiequon@chromium.org, Sep 6

Status: Fixed (was: Started)
►

Sign in to add a comment