Looks like starting from r584950, "default_apps" and "locales" folders are missing from the build archive.
At the same time there was a change in infra repo for zip builds, https://chromium-review.googlesource.com/c/chromium/tools/build/+/1184302.

pcc@ I'm not sure if this related to your change, but we do see change in binaries after builders picked up your change. Can you please take a look at this.
Build logs:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%20x64%20Builder%20Perf/37282
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%20x64%20Builder%20Perf/37281


Archived files:
https://pantheon.corp.google.com/storage/browser/chrome-test-builds/official-by-commit/Win%20x64%20Builder%20Perf?prefix=full-build-win32_584949
https://pantheon.corp.google.com/storage/browser/chrome-test-builds/official-by-commit/Win%20x64%20Builder%20Perf?prefix=full-build-win32_584950

https://chromium-review.googlesource.com/c/chromium/tools/build/+/1205950
seems like it would fix the issue but I'm not sure how to test it locally.

Confirmed that packages now contain default_apps and locales directories, e.g.
https://storage.cloud.google.com/chrome-test-builds/official-by-commit/Win%20x64%20Builder%20Perf/full-build-win32_588955.zip

Thank you for the help.

Tried in two machines with latest Chrome builds / revisions and still seeing the error 'Unable to find local data files, please reinstall' - attached screenshot for reference.

1. git pull
2. command python bisect_builds.py -o -a win64 -g 588439 -b 588718

re opening the issue.
 
pcc@, prasad@ - could you please check and let me know if anything missed from my end.

Deleted: bisect issue.png 27.8 KB

	bisect issue.png 27.8 KB View Download

588439 and 588718 are inside the range of revisions that were built incorrectly. Looks like the first good revision was 588909.

prasadv, is there any way that we can rebuild the bad revisions, i.e. 584950 to 588908?

Thank you so much fixing this.
ligimole@, I checked https://pantheon.corp.google.com/storage/browser/chrome-test-builds/official-by-commit/Win%20x64%20Builder%20Perf/?prefix=full-build-win32_588909, looks like missing artifacts in the build archive are now available, can you please run the bisect and verify.

Please note that we've a dead range 584950 to 588908, which means bisect won't work for this range.

 Issue 723921  has been merged into this issue.

Thanks for the fix and information.

Tried with below (latest) ranges and script worked without any issues.

Revision: 589790 589799
Revision: 589731 589790
Revision: 589799 590119

Issue 887562 has been merged into this issue.

Thanks for finding this Ben!

Prasadv@, pcc@, I think we should build away to fix up the bad revisions.

In an ideal system, we could delete old builds from GCS and the builder would just notice and fix them up for us. This is one of the things that I'm hoping we could get by having CCI own this as a service. http://crbug.com/842362

I made a workaround for swarming-in-g3 code that simply makes a new locales directory and copies a saved en-US.pak file into it: https://critique.corp.google.com/#review/213856020 .

It seems like bisect-builds could easily implement something similar. Re-opening this in hopes that we can fix the dead zone!