New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 11
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 874090



Sign in to add a comment

SingleProcessMash browser test failures

Project Member Reported by rcui@chromium.org, Sep 4

Issue description

Bug to track browser tests failures and fixes for single process mash.
 
Labels: Proj-Mash-SingleProcess
Test failures:

TopControlsSlideControllerTest.TestScrollingPageAndSwitchingToNTP
TopControlsSlideControllerTest.TestFocusEditableElements
TopControlsSlideControllerTest.TestScrollingPage
TopControlsSlideControllerTest.TestClosingATab

First failing build:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34404

Suspected cl: https://chromium-review.googlesource.com/1117449

Notes: filter file for single process mash browser_tests not updated
Test failure:

PlatformAppBrowserTest.PictureInPicture


First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34244

Notes: flaky test
Test failure:

BrowserActionApiTest.TestPictureInPictureOnBrowserActionIconClick

First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34245

Notes: flaky test
Test failure:

MSE_ClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM/0

First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34245

Notes: flaky test
Test failures:

UnifiedAutoplaySettingBrowserTest.Allow
UnifiedAutoplaySettingBrowserTest.Block
AutoplayMetricsBrowserTest.RecordAutoplayAttemptUkm

Failing builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34250


Notes: flaky test
Blocking: 874090
Test failures:

RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometry
GalleryBrowserTestInGuestMode.CropImageOnDownloads
AppWindowAPITest.TestMinimize
GalleryBrowserTest.CropImageOnDownloads
GalleryBrowserTest.CropImageOnDrive
RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometry_GuestMode

Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34450

Suspected cl: https://chromium-review.googlesource.com/1195886?
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e8e7fe272317eda274b08658a15315fd46881ea

commit 4e8e7fe272317eda274b08658a15315fd46881ea
Author: Ryan Cui <rcui@chromium.org>
Date: Tue Sep 04 23:48:32 2018

Add webcontent touch browser tests to single process mash blacklist

The tests were added to the mash blacklist in crrev.com/c/1117449, and also
needs to be skipped for single process mash, per afakhry@.

BUG:  880584 
Change-Id: I9fb484cdb2ecef12fcf097b8e997e030db00c412
Reviewed-on: https://chromium-review.googlesource.com/1205530
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588693}
[modify] https://crrev.com/4e8e7fe272317eda274b08658a15315fd46881ea/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3829032af1f93c72ea489c2708ef66701ad00e64

commit 3829032af1f93c72ea489c2708ef66701ad00e64
Author: Ryan Cui <rcui@chromium.org>
Date: Wed Sep 05 00:51:00 2018

Add flaky SingleProcessMash browser_tests to filter file

Bug:  880584 
Change-Id: Id6b18746b1fe4c849336bd2b2ff18b1c3b95ff69
Reviewed-on: https://chromium-review.googlesource.com/1205796
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588722}
[modify] https://crrev.com/3829032af1f93c72ea489c2708ef66701ad00e64/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2788b7e36cb5807a7d3c4c62120e588da1de935

commit c2788b7e36cb5807a7d3c4c62120e588da1de935
Author: Ryan Cui <rcui@chromium.org>
Date: Thu Sep 06 01:46:36 2018

Update SingleProcessMash browser_tests filter

Pull in entries from the Mash filter file, for tests that are also failing in
Mash.  Also broadens filter coverage for some test classes using wildcards,
to reduce the chance of a failure from a flakiness or new tests being added.

Bug:  880584 
Change-Id: Ic9d782e24fbd9c136c09b480fce5123190a53b43
Reviewed-on: https://chromium-review.googlesource.com/1208451
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589084}
[modify] https://crrev.com/c2788b7e36cb5807a7d3c4c62120e588da1de935/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8977b622447814880a74eea67e977b5436c3544c

commit 8977b622447814880a74eea67e977b5436c3544c
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 06 22:27:16 2018

Mash: initialize kTopViewInset on app windows

This is necessary so the initial bounds can be calculated correctly.
The app window requests a size for the content bounds and
ClientSideNonClientFrameView tacks on kTopViewInset.

Bug:  880584 
Change-Id: I0584e6aef313cde4e17bcf7c58a59830815ff831
Reviewed-on: https://chromium-review.googlesource.com/1208937
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589341}
[modify] https://crrev.com/8977b622447814880a74eea67e977b5436c3544c/ui/views/mus/desktop_window_tree_host_mus.cc

Seeing these new encryption test failures:

MSE_ClearKey/EncryptedMediaTest.Playback_Encryption_CBCS/0
SRC_ExternalClearKey/EncryptedMediaTest.Playback_Multiple_VideoAudio_WebM/0

Failing builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34543

Notes: Check failed: (*mdp_iter)->task_runner && (*mdp_iter)->task_runner->RunsTasksInCurrentSequence(). MemoryDumpProvider "ContextProviderCommandBuffer" attempted to unregister itself in a racy way.

crrev.com/c/1212093 blacklists all EncryptedMediaTests until the race condition is addressed.

Ryan, are those tests racy in the non-mash browser_tests too?
@sky: these EncyptedMediaTests don't look flaky on the non-mash (regular) browser_tests.  See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#sortColumn=test&sortOrder=forward&builder=chromium.chromiumos%3Alinux-chromeos-rel for a sorted list of tests, and search for "EncyptedMediaTests".

This search actually uncovers a few other types encrypted media tests that need to be blacklisted.  Will send a CL for that shortly.

Also, once the SingleProcessMash browser_tests are added to the main waterfall we'll be able to track the flakiness of individual tests with the flakiness dashboard.
Labels: -Pri-3 Pri-1
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c08472ba89c88093f5ff2ab4ebc6b0191026226

commit 8c08472ba89c88093f5ff2ab4ebc6b0191026226
Author: Ryan Cui <rcui@chromium.org>
Date: Fri Sep 07 23:05:59 2018

Add more EncryptedMediaTests to SingleProcessMash browser_tests filter file

Bug:  880584 
Change-Id: I6272bf7e5b99353a0b0b4f8e944747da7b83c944
Reviewed-on: https://chromium-review.googlesource.com/1214177
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589708}
[modify] https://crrev.com/8c08472ba89c88093f5ff2ab4ebc6b0191026226/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Labels: -Pri-1 Pri-2
Test failures:

CrSettingsResetPageTest.All

Failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/13165

Notes: flaky test.  Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection()
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036dd350148a7c4be0f3c41f5d8ea860db6ec1a9

commit 036dd350148a7c4be0f3c41f5d8ea860db6ec1a9
Author: Ryan Cui <rcui@chromium.org>
Date: Tue Sep 11 17:18:47 2018

Filter file update for single_process_mash_browser_test

Add blacklist for CrSettingsResetPageTest.All (flaky) and
ExtensionWebRequestApiTest.WebRequestTypes (failing on ASAN bot).

Bug:  874090 
Bug:  882631 
Bug:  880584 
Change-Id: Ie2a5bee8de4497a470a064ea853805a0e74b685a
Reviewed-on: https://chromium-review.googlesource.com/1217710
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590366}
[modify] https://crrev.com/036dd350148a7c4be0f3c41f5d8ea860db6ec1a9/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Status: Fixed (was: Assigned)
Marking as fixed, now that the tests are running on the main waterfall/CQ.
CrSettingsResetPageTest.All is flaky regardless of mash.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsResetPageTest
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8563

[ RUN      ] CrSettingsResetPageTest.All
[4435:4435:1028/011618.768813:WARNING:chrome_browser_main_chromeos.cc(545)] Running as stub user with profile dir: test-user
[4435:4435:1028/011619.290882:WARNING:easy_unlock_service_regular.cc(632)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
[4435:4435:1028/011619.290963:INFO:easy_unlock_service_regular.cc(163)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices().
[4435:4435:1028/011619.400304:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[4435:4435:1028/011619.400467:WARNING:remote_commands_service.cc(40)] Client is not registered.
[4435:4435:1028/011619.400630:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[4435:4435:1028/011619.400768:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[4435:4435:1028/011619.400876:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[4435:4435:1028/011619.400980:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[4435:4435:1028/011619.581256:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[4435:4435:1028/011620.206785:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart()
[4435:4435:1028/011620.206874:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued.
[4435:4435:1028/011620.207147:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel.
[4435:4435:1028/011620.207771:INFO:device_sync_service.cc(31)] DeviceSyncService::OnStart()
[4435:4435:1028/011620.210219:INFO:device_sync_service.cc(48)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync.
[4435:4435:1028/011620.212959:INFO:multidevice_setup_service.cc(62)] MultiDeviceSetupService::OnStart()
[4435:4435:1028/011620.213212:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[4435:4435:1028/011620.311942:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service.
[4435:4435:1028/011620.389387:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[4435:4435:1028/011620.597696:INFO:multidevice_setup_service.cc(75)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup.
[4435:4435:1028/011621.034352:INFO:tether_service.cc(188)] TetherService has started. Initial user preference value: 1
[4435:4435:1028/011621.784016:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
[4435:4435:1028/011622.701644:WARNING:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442)
[4435:4435:1028/011623.327139:INFO:CONSOLE(1269)] "Running TestCase CrSettingsResetPageTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1269)
[4435:4435:1028/011623.513416:WARNING:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7fcdbd59b47d base::debug::StackTrace::StackTrace()
#1 0x7fcdbd29cdea base::debug::StackTrace::StackTrace()
#2 0x000009206ed2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7fcd8b425cb0 <unknown>
#4 0x7fcd8b4ed6d3 epoll_wait
#5 0x7fcdbd64988f epoll_dispatch
#6 0x7fcdbd63d015 event_base_loop
#7 0x7fcdbd5ed672 base::MessagePumpLibevent::Run()
#8 0x7fcdbd32fe8e base::MessageLoop::Run()
#9 0x7fcdbd3dd832 base::RunLoop::Run()
#10 0x00000929e9ae content::RunThisRunLoop()
#11 0x00000ea3bb06 WebUITestHandler::WaitForResult()
#12 0x00000ea3b51a WebUITestHandler::RunJavaScriptTestWithResult()
#13 0x000007e0fa0b WebUIBrowserTest::RunJavascriptUsingHandler()
#14 0x000007e11614 WebUIBrowserTest::RunJavascriptAsyncTest()
#15 0x000007e10b35 WebUIBrowserTest::RunJavascriptTestF()
#16 0x000003598429 CrSettingsResetPageTest_All_Test::RunTestOnMainThread()
#17 0x0000092053e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#18 0x000000b7433d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#19 0x000000b74284 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#20 0x000009208295 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#21 0x0000092081cc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#22 0x000000b6498d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#23 0x000007f6663d ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#24 0x000007f646a8 ChromeBrowserMainParts::PreMainMessageLoopRun()
#25 0x0000039cafb6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()

Sign in to add a comment