New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Center edit custom link dialog in viewport

Project Member Reported by kristip...@chromium.org, Sep 4

Issue description

Currently centered in the ntp-contents div.

See https://screenshot.googleplex.com/hFKmyPPLimR.png
 
Cc: -ramyan@google.com ramyan@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7790d54ffed5d70ef5655d018bd4fb7786207842

commit 7790d54ffed5d70ef5655d018bd4fb7786207842
Author: kristipark <kristipark@chromium.org>
Date: Wed Sep 05 13:55:39 2018

[NTP] Center edit custom link dialog in the viewport

Centers the dialog in the viewport rather than the ntp-contents div.

Before: https://screenshot.googleplex.com/kk5zQAxuCTr.png
After: https://screenshot.googleplex.com/NE4asURv2Dp.png

Bug:  880582 
Change-Id: If5eac9aaf3bfd1d8e778aa684d6acffd874bab6d
Reviewed-on: https://chromium-review.googlesource.com/1205671
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588851}
[modify] https://crrev.com/7790d54ffed5d70ef5655d018bd4fb7786207842/chrome/browser/resources/local_ntp/local_ntp.css

Labels: TE-Verified-71.0.3544.0 TE-Verified-M71
Able to reproduce this issue on build without fix hence verifying the fix on latest canary 71.0.3544.0 using Mac 10.13.6, Windows 10 and Debian.

Now Edit custom link is seen centered in the viewport . Attaching screenshots for reference.

As fix is working as expected adding Verified labels.

Thanks!
Center aligned_withfix.png
284 KB View Download
Cc: ainslie@chromium.org bklmn@chromium.org
Labels: AddToRemoteNTP
Labels: -AddToRemoteNTP SupportedInRemoteNTP

Sign in to add a comment