New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880571 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 774675



Sign in to add a comment

[Findit] Flake Analyzer - Does not print the failed build / buildbot name on bug

Project Member Reported by ssid@chromium.org, Sep 4

Issue description

Link to Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ubWVtb3J5L0xpbnV4IFRTYW4gVGVzdHMvMjU0NDEvY29tcG9uZW50c191bml0dGVzdHMvVkhKaFkybHVaMU5oYlhCc1pWQnliMlpwYkdWeVZHVnpkQzVLYjJsdVVuVnVibWx1WjFSeVlXTnBibWM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

See  issue 880526 . The bug got filed with culprit CL link. But there is no mention of which bulidbot is failing test. It would be good to have link as well, or some info on how to find the failed build.

It will be awesome if it also printed the test failure log to the bug too.
 
Labels: -Test-Findit-Wrong Type-Feature
Owner: lijeffrey@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8ea480761ebbf9bee87a92d46da93adf99a35974

commit 8ea480761ebbf9bee87a92d46da93adf99a35974
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Sep 07 21:52:20 2018

[Findit] Flake Analyzer - Show full analysis info by default

Discoverability of features has been mentioned as feedback from Flake
Analyzer customers. We should show useful information by default, not
hide it.

Bug:  880571 
Change-Id: If741afd4fc7e182aa5aacd1cfbe489159c8b244d
Reviewed-on: https://chromium-review.googlesource.com/1211692
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17453}
[modify] https://crrev.com/8ea480761ebbf9bee87a92d46da93adf99a35974/appengine/findit/ui/elements/analysis/flake/flake-analysis-info.html
[modify] https://crrev.com/8ea480761ebbf9bee87a92d46da93adf99a35974/appengine/findit/ui/elements/analysis/flake/flake-test-info.html

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b22c301646643b06512568c029dfb1626660f404

commit b22c301646643b06512568c029dfb1626660f404
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Sep 10 19:15:48 2018

[Findit] Flake Analyzer - Surface failed build instance to bug

A user has requested an instance of a failed build be surfaced to the
bug due to the link to the flake occurrence being undiscoverable in the
result UI.

This is a temporary solution, as it still relies on the buildbot build
number to generate the link, which is to be deprecreated. The switch to
build id will be in a follow up, but that change should be invisible to
this one.

Bug:  880571 
Change-Id: I4201a93d37084c749b81b517e32ae993701bc176
Reviewed-on: https://chromium-review.googlesource.com/1208022
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17482}
[add] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/services/test/build_url_test.py
[modify] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/model/flake/analysis/master_flake_analysis.py
[modify] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/pipelines/flake_failure/test/update_monorail_bug_pipeline_test.py
[add] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/services/build_url.py
[modify] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/services/flake_failure/test/flake_report_util_test.py
[modify] https://crrev.com/b22c301646643b06512568c029dfb1626660f404/appengine/findit/services/flake_failure/flake_report_util.py

Status: Fixed (was: Started)
Bugs should now have example builds linked to them. Surfacing a link to the stdio log of the failed test will be tracked in  issue 881635 
Blocking: 774675
Cc: lijeffrey@chromium.org
 Issue 779258  has been merged into this issue.

Sign in to add a comment