Print Preview affirmative action button is on the wrong side on Windows / Chrome OS |
||||||||||||||||
Issue descriptionChrome Version: 69.x, 70.x, 71.x OS: Windows, Chrome OS What steps will reproduce the problem? (1) If necessary, turn on "Enable new Print Preview UI" in chrome://flags and restart the browser. (2) Print What is the expected result? On Windows and Chrome OS, the Print/Save button should be on the left, and the Cancel button should be on the right. What happens instead? The Print/Save button is on the right, and the Cancel button is on the left. Note: For Chrome OS, we'll eventually want to flip the buttons for bug 844167 . Before we do that, we should fix this first, and merge this fix to M70, and possibly M69.
,
Sep 5
The last time we touched the button reversal code was for bug 383955 , so let's also double check and make sure the buttons work well for screen readers.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bbf02bbd11bd5ac6736c6b931651091f6d01b49 commit 3bbf02bbd11bd5ac6736c6b931651091f6d01b49 Author: rbpotter <rbpotter@chromium.org> Date: Wed Sep 05 02:32:40 2018 Print Preview: Fix button reversal Print button should be on the left on Windows and Chrome OS. Bug: 880562 Change-Id: If4a0cec12e506846444f753361653b7407db99e7 Reviewed-on: https://chromium-review.googlesource.com/1205201 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588745} [modify] https://crrev.com/3bbf02bbd11bd5ac6736c6b931651091f6d01b49/chrome/browser/resources/print_preview/new/header.html [modify] https://crrev.com/3bbf02bbd11bd5ac6736c6b931651091f6d01b49/chrome/browser/resources/print_preview/print_preview_resources.grd
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a71bb8f222f16b93fd8bdf478cc7a10de52f35 commit 67a71bb8f222f16b93fd8bdf478cc7a10de52f35 Author: rbpotter <rbpotter@chromium.org> Date: Wed Sep 05 02:38:30 2018 Print Preview: Add test to verify button order Add automated test to verify that there are 2 buttons in the print header and they are in the correct order for all platforms. Split off parent CL, which contains a fix for the bug linked. Bug: 880562 Change-Id: I3472561dd1af7e75a86bf4821fb4ae42e82a0d5f Reviewed-on: https://chromium-review.googlesource.com/1205717 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588746} [modify] https://crrev.com/67a71bb8f222f16b93fd8bdf478cc7a10de52f35/chrome/test/data/webui/print_preview/header_test.js [modify] https://crrev.com/67a71bb8f222f16b93fd8bdf478cc7a10de52f35/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
,
Sep 6
Verified this fix on Windows 10 in Canary 71.0.3544.2. Print button appears on the left of the Cancel button in the new Print Preview UI. Requesting a merge to M-70 for the change in comment 3. This is a very safe, small change (7 lines) to an HTML file and corresponding .grd entry - no JS or C++ changes. It is also verified by the automated test added in the CL linked in comment 4. Moreover, this change impacts only the new Print Preview UI, which is behind a finch flag that can be turned off if necessary.
,
Sep 6
This bug requires manual review: There is .grd file changes and we are only 39 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6
Note that the .grd changes are not string changes, but are rather just a change to the entry for an HTML file.
,
Sep 6
approved - branch:3538
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a0d4a31affe8c8885a4a3ec210505500f05364 commit 87a0d4a31affe8c8885a4a3ec210505500f05364 Author: rbpotter <rbpotter@chromium.org> Date: Fri Sep 07 00:42:01 2018 Print Preview: Fix button reversal (M70) Print button should be on the left on Windows and Chrome OS. Bug: 880562 Change-Id: If4a0cec12e506846444f753361653b7407db99e7 Reviewed-on: https://chromium-review.googlesource.com/1205201 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588745}(cherry picked from commit 3bbf02bbd11bd5ac6736c6b931651091f6d01b49) TBR: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1212222 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#122} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/87a0d4a31affe8c8885a4a3ec210505500f05364/chrome/browser/resources/print_preview/new/header.html [modify] https://crrev.com/87a0d4a31affe8c8885a4a3ec210505500f05364/chrome/browser/resources/print_preview/print_preview_resources.grd
,
Sep 10
Verified this on 70.0.3538.14 today on Windows 10 - Print button appears on the left hand side with the "New Print Preview UI" flag enabled. Also have not seen any changes in the metrics on Canary channel that would indicate a problem introduced by this change. Requesting a merge to 69 for the change in comment 3. Please see comments 5 and 7 for an explanation of why this change is safe. Note that the finch flag mentioned in comment 5 is currently off by default for all Windows and ChromeOS users on Stable 69.
,
Sep 10
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
We already cut M69 Desktop stable RC for release tomorrow. So we won't be take to take this merge in. We might be able to pick up for future M69 respin (if any) for Desktop. Seems like this change is more applicable Chrome OS, so adding cindyb@ (Chrome OS M69 TPM) for merge review.
,
Sep 10
,
Sep 10
Merge approved, M69.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a873c5580d6d783caf9619cff935ea2562b7f5 commit 52a873c5580d6d783caf9619cff935ea2562b7f5 Author: rbpotter <rbpotter@chromium.org> Date: Mon Sep 10 22:42:40 2018 Print Preview: Fix button reversal (M69) Print button should be on the left on Windows and Chrome OS. Bug: 880562 Change-Id: If4a0cec12e506846444f753361653b7407db99e7 Reviewed-on: https://chromium-review.googlesource.com/1205201 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588745}(cherry picked from commit 3bbf02bbd11bd5ac6736c6b931651091f6d01b49) TBR: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1217760 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#922} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/52a873c5580d6d783caf9619cff935ea2562b7f5/chrome/browser/resources/print_preview/new/header.html [modify] https://crrev.com/52a873c5580d6d783caf9619cff935ea2562b7f5/chrome/browser/resources/print_preview/print_preview_resources.grd
,
Sep 12
Verified the fix on Windows-10 using Chrome version #70.0.3538.16 as per the comment#0. Attaching screenshot for reference. Observed print/save button towards left and cancel button towards right. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!!
,
Sep 14
This change is merged to M69. Pls verify this bug on M69 build #69.0.3497.96 (currently building) tomorrow morning and update result here. Thank you.
,
Sep 14
Verified on 69.0.3497.95 on Windows 10 - print button appears on the left with new print preview flag enabled.
,
Sep 14
,
Sep 14
The NextAction date has arrived: 2018-09-14
,
Sep 14
Able to reproduce the issue on the build without fix #69.0.3444.0 using Windows 10. Verified the fix on Windows 10, as per comment#0 on latest chrome 69.0.3497.96. Attached screenshot for reference. Observed that the print button appears on left and cancel button appears on right. Hence the fix is working as expected. Adding verified labels. Thanks.!
,
Sep 17
Verified the fix on Windows-10 using Chrome version #69.0.3497.100 as per the comment#0. Attaching screenshot for reference. Observed print/save button towards left and cancel button towards right. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by rbpotter@chromium.org
, Sep 4