Issue metadata
Sign in to add a comment
|
Google tts engine is unloaded when tts settings page makes tts queries |
||||||||||||||||||||||||
Issue description- open chrome://settings/manageAccessibility/tts result: voices list contains ~30 voices expected: voices list contains ~10 voices - inspect all open renderers through dev tools result: no tts engine expected: a background page (chrome://gjj...) should be present (the tts engine background page).
,
Sep 5
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3865fddcdf9d5c12c512b96294d376235322b05e commit 3865fddcdf9d5c12c512b96294d376235322b05e Author: David Tseng <dtseng@chromium.org> Date: Wed Sep 05 21:23:57 2018 Fix tts engine load The Tts engine component extension was converted to an event page in: https://chromium-review.googlesource.com/c/chromiumos/platform/assets/+/447000/5/speech_synthesis/patts/manifest.json This means the extension is aggressively unloaded. In particular, on startup, it is not loaded until the extension receives a request. In code paths that require the engine to be awake, explicitly wake the event page. Bug: 880556 Change-Id: If49f3b59440bd64a9a0af7382f25e054285a26bf Reviewed-on: https://chromium-review.googlesource.com/1205092 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#589004} [modify] https://crrev.com/3865fddcdf9d5c12c512b96294d376235322b05e/chrome/browser/resources/settings/a11y_page/tts_subpage.html [modify] https://crrev.com/3865fddcdf9d5c12c512b96294d376235322b05e/chrome/browser/resources/settings/a11y_page/tts_subpage.js [modify] https://crrev.com/3865fddcdf9d5c12c512b96294d376235322b05e/chrome/browser/ui/webui/settings/tts_handler.cc [modify] https://crrev.com/3865fddcdf9d5c12c512b96294d376235322b05e/chrome/browser/ui/webui/settings/tts_handler.h
,
Sep 6
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e806df3c14927944feb0409fa24be6d074217cd9 commit e806df3c14927944feb0409fa24be6d074217cd9 Author: David Tseng <dtseng@chromium.org> Date: Mon Sep 10 16:27:00 2018 Merge to m70: Fix tts engine load The Tts engine component extension was converted to an event page in: https://chromium-review.googlesource.com/c/chromiumos/platform/assets/+/447000/5/speech_synthesis/patts/manifest.json This means the extension is aggressively unloaded. In particular, on startup, it is not loaded until the extension receives a request. In code paths that require the engine to be awake, explicitly wake the event page. (cherry picked from commit 3865fddcdf9d5c12c512b96294d376235322b05e) Bug: 880556 Change-Id: If49f3b59440bd64a9a0af7382f25e054285a26bf Reviewed-on: https://chromium-review.googlesource.com/1205092 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589004} Reviewed-on: https://chromium-review.googlesource.com/1216982 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#221} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e806df3c14927944feb0409fa24be6d074217cd9/chrome/browser/resources/settings/a11y_page/tts_subpage.html [modify] https://crrev.com/e806df3c14927944feb0409fa24be6d074217cd9/chrome/browser/resources/settings/a11y_page/tts_subpage.js [modify] https://crrev.com/e806df3c14927944feb0409fa24be6d074217cd9/chrome/browser/ui/webui/settings/tts_handler.cc [modify] https://crrev.com/e806df3c14927944feb0409fa24be6d074217cd9/chrome/browser/ui/webui/settings/tts_handler.h
,
Sep 10
,
Sep 18
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Sep 5