Not checking autofill policy & chrome flag before offering migration from settings page |
|||||
Issue descriptionCurrent implementation in settings page only checks for user capability (signed in, sync on, local card valid, etc) [1], we need to add the check for autofill policy and chrome flag (i18n control) also.
,
Sep 4
[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js?l=383-430&rcl=27507d2949dcd66de55f2fc06ffe638b2e5c971b Currently check on Upstream [2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_experiments.cc?l=102-146&rcl=27507d2949dcd66de55f2fc06ffe638b2e5c971b
,
Sep 13
,
Oct 4
,
Oct 10
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ceb3644ab3bd2ce48a96e13d921913bf627154 commit e1ceb3644ab3bd2ce48a96e13d921913bf627154 Author: siyua <siyua@chromium.org> Date: Wed Oct 10 03:01:34 2018 Adding missing checks for card migration settings page triggering point. 1) Check if Autofill Upstream feature is enabled. 2) Check if the user has a secondary passphrase. 3) Check if upload to Google Payments is active. 4) Check if email domain is allowed. The goal is to replicate the checks here [1] in settings. [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_experiments.cc?l=102-146&rcl=27507d2949dcd66de55f2fc06ffe638b2e5c971b Bug: 880554 , 852904 Change-Id: I03d7cc79e16000580f5ecf29fdf1ccbbd19a355a Reviewed-on: https://chromium-review.googlesource.com/c/1269723 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#598194} [modify] https://crrev.com/e1ceb3644ab3bd2ce48a96e13d921913bf627154/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js [modify] https://crrev.com/e1ceb3644ab3bd2ce48a96e13d921913bf627154/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/e1ceb3644ab3bd2ce48a96e13d921913bf627154/chrome/test/data/webui/settings/payments_section_test.js
,
Oct 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ma...@chromium.org
, Sep 4