Autofill setting page used obsolete pref and led to undefined behavior |
||||||||
Issue descriptionSee screenshot: https://screenshot.googleplex.com/O6gW7rJvQsx.png
,
Sep 5
,
Sep 5
,
Sep 5
Are you not looking for the "credit card enabled" preference?
,
Sep 5
Hi Mathieu, we are supposed to look for both and call eitherIsDisabled_(prefs.autofill.enabled.value,prefs.autofill.credit_card_enabled.value) But since prefs.autofill.enabled is not defined when using prefs.autofill.enabled.value, it will blown up, nothing is evaluated and the behavior is undefined in this case. (Add is not disabled and migration button shows up)
,
Sep 5
The master preference (autofill.enabled) is no longer used. You could only check credit_card_enabled.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45e35ec4e91b327307ab8e0bb896ce08e5381d7a commit 45e35ec4e91b327307ab8e0bb896ce08e5381d7a Author: Jason Guo <jiahuiguo@chromium.org> Date: Wed Sep 05 22:04:50 2018 [Autofill] Fix pref name in settings. Details please refer to the bug threads. Bug: 880552 , 880833 Change-Id: I90705523da9c513a70990647915422b574b02753 Reviewed-on: https://chromium-review.googlesource.com/1205536 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589019} [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/45e35ec4e91b327307ab8e0bb896ce08e5381d7a/chrome/test/data/webui/settings/payments_section_test.js
,
Sep 6
,
Sep 6
,
Sep 6
,
Sep 6
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a3d5a73a76fd3a1c02df491461eb42b636f5bea commit 5a3d5a73a76fd3a1c02df491461eb42b636f5bea Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Sep 07 00:29:25 2018 [Autofill] Fix pref name in settings. Details please refer to the bug threads. TBR=jiahuiguo@chromium.org (cherry picked from commit 45e35ec4e91b327307ab8e0bb896ce08e5381d7a) Bug: 880552 , 880833 Change-Id: I90705523da9c513a70990647915422b574b02753 Reviewed-on: https://chromium-review.googlesource.com/1205536 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589019} Reviewed-on: https://chromium-review.googlesource.com/1211920 Cr-Commit-Position: refs/branch-heads/3538@{#120} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/test/data/webui/settings/autofill_section_test.js [modify] https://crrev.com/5a3d5a73a76fd3a1c02df491461eb42b636f5bea/chrome/test/data/webui/settings/payments_section_test.js
,
Sep 12
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jiahuiguo@chromium.org
, Sep 5