New issue
Advanced search Search tips

Issue 880542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Install Firefox native messaging manifests

Project Member Reported by rkjnsn@chromium.org, Sep 4

Issue description

As we plan to release a Firefox extension for the Chrome Remote Desktop website, we need to include native messaging manifests for it in our host installers.
 
Mac and Linux changes have landed. Windows was complicated by the fact that we need to write to the 64-bit registry from our 32-bit installer, and is still in progress.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f854c2788d871270f5b24cfcab76da2a97ba12

commit c7f854c2788d871270f5b24cfcab76da2a97ba12
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Sat Sep 08 00:05:11 2018

Install Firefox native messaging reg keys on Windows

While Chrome checks both the 32- and 64-bit registries to discover
native messaging hosts, Firefox only checks the native registry. This
poses a challenge, as 32-bit installers generally aren't allowed to
install 64-bit components (such as registry keys). However, it turns out
that it is possible to suppress the resulting error, and this CL does
just that, allowing the required keys to be installed in the native
registry on 64-bit Windows.

Bug:  880542 
Change-Id: I2552d24ec7dd2e7cce8febdc42b048a1e5caf568
Reviewed-on: https://chromium-review.googlesource.com/1213956
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589725}
[modify] https://crrev.com/c7f854c2788d871270f5b24cfcab76da2a97ba12/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/c7f854c2788d871270f5b24cfcab76da2a97ba12/remoting/host/installer/win/chromoting.wxs
[modify] https://crrev.com/c7f854c2788d871270f5b24cfcab76da2a97ba12/remoting/host/installer/win/parameters.json

Labels: Merge-Request-70
This is an installer-only change for Chrome Remote Desktop on Windows. The resulting installer has been tested and no other code is affected.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 11

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c465322e1417ce77fa3db1a51443096c3212ec79

commit c465322e1417ce77fa3db1a51443096c3212ec79
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Wed Sep 12 17:10:06 2018

Install Firefox native messaging reg keys on Windows

While Chrome checks both the 32- and 64-bit registries to discover
native messaging hosts, Firefox only checks the native registry. This
poses a challenge, as 32-bit installers generally aren't allowed to
install 64-bit components (such as registry keys). However, it turns out
that it is possible to suppress the resulting error, and this CL does
just that, allowing the required keys to be installed in the native
registry on 64-bit Windows.

Bug:  880542 
Change-Id: I2552d24ec7dd2e7cce8febdc42b048a1e5caf568
Reviewed-on: https://chromium-review.googlesource.com/1213956
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589725}(cherry picked from commit c7f854c2788d871270f5b24cfcab76da2a97ba12)
Reviewed-on: https://chromium-review.googlesource.com/1222186
Cr-Commit-Position: refs/branch-heads/3538@{#331}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c465322e1417ce77fa3db1a51443096c3212ec79/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/c465322e1417ce77fa3db1a51443096c3212ec79/remoting/host/installer/win/chromoting.wxs
[modify] https://crrev.com/c465322e1417ce77fa3db1a51443096c3212ec79/remoting/host/installer/win/parameters.json

Status: Fixed (was: Started)
Manifests for all platforms are in M70.

Sign in to add a comment