unsupported operand type(s) for -: 'NoneType' and 'datetime.timedelta' |
|||||
Issue description/internal/taskqueue/machine-provider-manage fails with HTTP 500 on chromium-swarm with error unsupported operand type(s) for -: 'NoneType' and 'datetime.timedelta' in https://chromium.googlesource.com/infra/luci/luci-py/+/353c65d6f9db06199c6a50253f7a9f366649c52d/appengine/swarming/server/lease_management.py#1138 probably because of the introduction of infinite leases
,
Sep 4
... but looks like not this one.
,
Sep 4
Will write a fix, it's relatively easy.
,
Sep 4
I wrote https://chromium-review.googlesource.com/1205315 but didn't have time to write a unit test, which I think would be a good idea. Passing back to smut@
,
Sep 5
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/6e61688935326fea230c26b842781793c83ff917 commit 6e61688935326fea230c26b842781793c83ff917 Author: smut <smut@google.com> Date: Wed Sep 05 00:13:19 2018 [Swarming] Reject early_release_secs when lease_indefinitely is set Bug: 880537 Change-Id: I1c005faf83ebf8fb055a35cc90d729c461a29796 Reviewed-on: https://chromium-review.googlesource.com/1205331 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: smut <smut@google.com> [modify] https://crrev.com/6e61688935326fea230c26b842781793c83ff917/appengine/swarming/server/bot_groups_config.py [modify] https://crrev.com/6e61688935326fea230c26b842781793c83ff917/appengine/swarming/server/bot_groups_config_test.py [modify] https://crrev.com/6e61688935326fea230c26b842781793c83ff917/appengine/swarming/server/lease_management.py
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/667810e4e92b2572492d659bf88835d68a9346b1 commit 667810e4e92b2572492d659bf88835d68a9346b1 Author: smut <smut@google.com> Date: Wed Sep 05 12:58:30 2018 [Swarming] Don't check early release time for indefinite leases Bug: 880537 Change-Id: Icb688990e082d69db7970bd0c1515300ebb09b3a Reviewed-on: https://chromium-review.googlesource.com/1206071 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/667810e4e92b2572492d659bf88835d68a9346b1/appengine/swarming/server/lease_management.py [modify] https://crrev.com/667810e4e92b2572492d659bf88835d68a9346b1/appengine/swarming/server/lease_management_test.py
,
Sep 7
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mar...@chromium.org
, Sep 4