New issue
Advanced search Search tips

Issue 880524 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 873684



Sign in to add a comment

Send pointerrawmove when in pointerlock

Project Member Reported by nzolghadr@chromium.org, Sep 4

Issue description

Unify the path for sending pointerrawmove in pointerlock mode with the normal event processing path.
 
Blocking: 873684
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4998c17c3dbca909f1a6148f8f72cf144d96139d

commit 4998c17c3dbca909f1a6148f8f72cf144d96139d
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Sep 14 15:13:13 2018

Send pointerrawmove when in pointerlock

Unify the path for sending pointerrawmove in pointerlock
mode with the normal event processing path.

Bug:  880524 
Change-Id: I021261e0107b6172da02684cf82e0f46df304eba
Reviewed-on: https://chromium-review.googlesource.com/1205476
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591347}
[modify] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_pointerrawmove_in_pointerlock-manual.html
[add] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/WebKit/LayoutTests/external/wpt/pointerevents/resources/pointerevent_pointerrawmove_in_pointerlock-iframe.html
[modify] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/4998c17c3dbca909f1a6148f8f72cf144d96139d/third_party/blink/renderer/core/input/pointer_event_manager.cc

Labels: Merge-Request-70
Can you please mark which OS's this is impacting?
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 15

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
abdulsyed@ I added the all the affected platforms. This whole change is behind the flag and doesn't have any effect on the normal Chrome running. But it is needed for some teams testing with that feature on.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fba8d89a6e773790d85ca239c8e8b85833957651

commit fba8d89a6e773790d85ca239c8e8b85833957651
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Sep 18 14:20:44 2018

Send pointerrawmove when in pointerlock

Unify the path for sending pointerrawmove in pointerlock
mode with the normal event processing path.

Bug:  880524 
Change-Id: I021261e0107b6172da02684cf82e0f46df304eba
Reviewed-on: https://chromium-review.googlesource.com/1205476
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591347}(cherry picked from commit 4998c17c3dbca909f1a6148f8f72cf144d96139d)
Reviewed-on: https://chromium-review.googlesource.com/1230575
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#490}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_pointerrawmove_in_pointerlock-manual.html
[add] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/WebKit/LayoutTests/external/wpt/pointerevents/resources/pointerevent_pointerrawmove_in_pointerlock-iframe.html
[modify] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/fba8d89a6e773790d85ca239c8e8b85833957651/third_party/blink/renderer/core/input/pointer_event_manager.cc

Status: Fixed (was: Started)

Sign in to add a comment