New issue
Advanced search Search tips

Issue 880519 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
layoutng


Sign in to add a comment

[LayoutNG] DevTools timeline invalidation tracking should track NGPaintFragment invalidations

Project Member Reported by xiaoche...@chromium.org, Sep 4 
Note: DevTools timeline invalidation tracking is still an experimental feature, so this doesn't block LayoutNG launching

The feature tracks paint invalidation by logging a trace event in ObjectPaintInvalidator::InvalidateDisplayItemClient():

if (&client == &object_) {
  TRACE_EVENT_INSTANT1(
      TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"),
      "PaintInvalidationTracking", TRACE_EVENT_SCOPE_THREAD, "data",
      InspectorPaintInvalidationTrackingEvent::Data(object_));
}


This currently only tracks LayoutObject invalidations. More work is needed if we move more painting work from LayoutObject to NGPaintFragment, and decide to ship DevTools invalidation tracking.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df79950d90a7e9a5caf788bd35c877e901b35088

commit df79950d90a7e9a5caf788bd35c877e901b35088
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Sep 06 04:43:58 2018

[LayoutNG] Trace block flow invalidation for devtools

This patch allows block-level NGPaintFragment invalidations to be
traced, to make relevant layout tests pass.

Note: This is a hacky fix only for making tests pass, since devtools
invalidation tracking is still an experimental feature. More work will
be done if the feature is launched.

Bug: 880519
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6bfcd0204a66ea266e2de7a6a421fea29dc70fbf
Reviewed-on: https://chromium-review.googlesource.com/1204851
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589101}
[modify] https://crrev.com/df79950d90a7e9a5caf788bd35c877e901b35088/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/df79950d90a7e9a5caf788bd35c877e901b35088/third_party/blink/renderer/core/paint/object_paint_invalidator.cc

Comment 2 by pfeldman@chromium.org, Dec 4

Components: -Platform>DevTools>Tracing
►

Sign in to add a comment