mash: Tab should move focus to system tray when Android app is running |
||
Issue descriptionToT chrome c600823b01b687f788b2cf2ade1d55c7d1c41772 on eve with --enable-features=SingleProcessMash * Sign in * Launch Android app (e.g. Play Books) * Tap on system tray to open it * Press tab repeatedly Expected: System tray should activate and system tray buttons should highlight. Actual: Focus moves inside the Android app This is covered by ClientControlledShellSurfaceTest.KeyboardNavigationWithUnifiedSystemTray in exo_unittests. The test also fails under SingleProcessMash.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63017c17a54ac7cdbcdcb3d32664349f632db0e5 commit 63017c17a54ac7cdbcdcb3d32664349f632db0e5 Author: James Cook <jamescook@chromium.org> Date: Fri Sep 21 18:30:21 2018 chromeos: Fix tabbing into system tray under SingleProcessMash TrayBubbleView uses a custom ui::EventHandler to activate the system tray bubble when the user presses the tab key. It was being registered with the wrong aura::Env under SingleProcessMash. Fixing this makes all exo_unittests pass under SingleProcessMash, so eliminate the test filter file. TBR=oshima@chromium.org Bug: 880515 Test: exo_unittests, manually follow steps in bug on veyron_minnie Change-Id: I69cbfd15b8c00499241f9b7ddb683e739ef14018 Reviewed-on: https://chromium-review.googlesource.com/1235117 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593268} [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/components/exo/BUILD.gn [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/testing/buildbot/chromium.memory.json [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/e94fb27bfaa6483f49464abe07b41caf2f748964/testing/buildbot/filters/chromeos.single_process_mash.exo_unittests.filter [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/testing/buildbot/test_suites.pyl [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/63017c17a54ac7cdbcdcb3d32664349f632db0e5/ui/views/bubble/tray_bubble_view.h
,
Sep 21
|
||
►
Sign in to add a comment |
||
Comment 1 by jamescook@chromium.org
, Sep 19Status: Started (was: Available)