New issue
Advanced search Search tips

Issue 880514 link

Starred by 1 user
Status: Fixed
Owner:
saklein@chromium.org
Closed: Sep 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

portageq command standardization.

Project Member Reported by saklein@chromium.org, Sep 4 
We have a number of users of different portageq commands (e.g. envvar, best_visible, match). The calls to portageq are not standardized, and often done as a one off RunCommand.

Each portageq action should be implemented in one location, the arguments to the methods standardized, and the actions should all funnel through a single method to actually make the portageq call.

Comment 1 by saklein@chromium.org, Sep 6

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4d3e327aa0b24c803a268d7d8703e31c8aff7c59

commit 4d3e327aa0b24c803a268d7d8703e31c8aff7c59
Author: Alex Klein <saklein@chromium.org>
Date: Mon Sep 17 20:17:36 2018

common-mk: portage_util: use new standardized portageq functions.

The portageq tool now has a standardized implementation for
the currently used actions. These are preferred over one-off
RunCommand implementations.

BUG= chromium:880514 
TEST=precq
CQ-DEPEND=CL:1211124

Change-Id: I1df7666187637f171e7bac0671e39779fe42a56b
Reviewed-on: https://chromium-review.googlesource.com/1211762
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4d3e327aa0b24c803a268d7d8703e31c8aff7c59/common-mk/platform2.py
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ecb8a340ec6e9ddc04e7b840b3ce7049dc20e526

commit ecb8a340ec6e9ddc04e7b840b3ce7049dc20e526
Author: Alex Klein <saklein@chromium.org>
Date: Mon Sep 17 20:17:35 2018

portage_util: Implement standardized portageq functions.

Several `portageq <action>` commands are implemented across
a number of files with one off RunCommands. This introduces
a single, standard implementation point for several of the
commands.

BUG= chromium:880514 
TEST=run_tests, new tests
CQ-DEPEND=CL:1211125

Change-Id: I9c4e63728e5736b6bf6c6f847c2293ac5b167ea3
Reviewed-on: https://chromium-review.googlesource.com/1211124
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ecb8a340ec6e9ddc04e7b840b3ce7049dc20e526/lib/portage_util_unittest.py
[modify] https://crrev.com/ecb8a340ec6e9ddc04e7b840b3ce7049dc20e526/lib/portage_util.py
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f78f3072c67d37ec0944aeced1953d62a70cf9c1

commit f78f3072c67d37ec0944aeced1953d62a70cf9c1
Author: Alex Klein <saklein@chromium.org>
Date: Mon Sep 17 20:17:36 2018

portage_util: Use new standardized portageq functions.

BUG= chromium:880514 
TEST=run_tests, new tests
CQ-DEPEND=CL:1211124

Change-Id: I078f41e76dc870e66957fe50b7e4bc862ff125b2
Reviewed-on: https://chromium-review.googlesource.com/1211125
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/scripts/cros_generate_local_binhosts.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/stages/afdo_stages_unittest.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/stages/afdo_stages.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/scripts/cros_portage_upgrade.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cros/test/image_test.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/stages/test_stages.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/cbuildbot_run.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/licensing/licenses_lib.py
[modify] https://crrev.com/f78f3072c67d37ec0944aeced1953d62a70cf9c1/cbuildbot/binhost.py

Comment 5 by saklein@chromium.org, Sep 20

Status: Fixed (was: Started)
►

Sign in to add a comment