New issue
Advanced search Search tips

Issue 880493 link

Starred by 2 users
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"TCPBoundSocketTest.ListenError" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 4 
"TCPBoundSocketTest.ListenError" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5UQ1BCb3VuZFNvY2tldFRlc3QuTGlzdGVuRXJyb3IM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by mmenke@chromium.org, Sep 4

Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
Already disabled
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Sep 5 

Detected 26 new flakes for test/step "TCPBoundSocketTest.ListenError". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh5UQ1BCb3VuZFNvY2tldFRlc3QuTGlzdGVuRXJyb3IM. This message was posted automatically by the chromium-try-flakes app.

Comment 3 by yhirano@chromium.org, Sep 10

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9ac80abbd502800b8a77101482a1285f7fc9a8

commit 8f9ac80abbd502800b8a77101482a1285f7fc9a8
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Sep 19 13:33:27 2018

Fix and re-enable TCPBoundSocketTest.ListenError and .BindError.

The tests perform operations on sockets that are expected to fail,
and verifies they fail as expected. Unfortunately, some platforms
can return one of two errors. This CL updates the tests to allow
both errors.

Also removes a bunch of extraneous "network::"'s

Bug:  880492 , 880493 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id085ece9ef0cf2e0b1581d6969f0295dd86910b8
Reviewed-on: https://chromium-review.googlesource.com/1231737
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592381}
[modify] https://crrev.com/8f9ac80abbd502800b8a77101482a1285f7fc9a8/services/network/tcp_bound_socket_unittest.cc

Comment 5 by mmenke@chromium.org, Sep 19

Status: Fixed (was: Assigned)
Hope that takes care of it.
►

Sign in to add a comment