New issue
Advanced search Search tips

Issue 880492 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"TCPBoundSocketTest.BindError" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 4

Issue description

"TCPBoundSocketTest.BindError" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 5 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxUQ1BCb3VuZFNvY2tldFRlc3QuQmluZEVycm9yDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: tsepez@chromium.org mmenke@chromium.org morlovich@chromium.org
This is caused by below CL?
https://chromium-review.googlesource.com/c/chromium/src/+/1198314

Detected 40 new flakes for test/step "TCPBoundSocketTest.BindError". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxUQ1BCb3VuZFNvY2tldFRlc3QuQmluZEVycm9yDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/243a4fcc092558d7379ff59dadfcf02f6afba8f7

commit 243a4fcc092558d7379ff59dadfcf02f6afba8f7
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Sep 05 00:33:28 2018

Disable TCPBoundSocketTest.BindError

It's flaking.  I'll fix it tomorrow.

TBR=morlovich@chromium.org
NOTRY=true

Bug:  880492 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia1b1122c295ad5cd922e0b9914009efbb7e5e307
Reviewed-on: https://chromium-review.googlesource.com/1205715
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588714}
[modify] https://crrev.com/243a4fcc092558d7379ff59dadfcf02f6afba8f7/services/network/tcp_bound_socket_unittest.cc

Cc: yhirano@chromium.org
Labels: -Sheriff-Chromium
Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9ac80abbd502800b8a77101482a1285f7fc9a8

commit 8f9ac80abbd502800b8a77101482a1285f7fc9a8
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Sep 19 13:33:27 2018

Fix and re-enable TCPBoundSocketTest.ListenError and .BindError.

The tests perform operations on sockets that are expected to fail,
and verifies they fail as expected. Unfortunately, some platforms
can return one of two errors. This CL updates the tests to allow
both errors.

Also removes a bunch of extraneous "network::"'s

Bug:  880492 , 880493 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id085ece9ef0cf2e0b1581d6969f0295dd86910b8
Reviewed-on: https://chromium-review.googlesource.com/1231737
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592381}
[modify] https://crrev.com/8f9ac80abbd502800b8a77101482a1285f7fc9a8/services/network/tcp_bound_socket_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment