New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 880486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Show offline indicator via top snackbar

Project Member Reported by jianli@chromium.org, Sep 4

Issue description

Show offline indicator via top snackbar
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450

commit a0a9d41ab84b666e7f9fc4d83432e0b6e370b450
Author: Jian Li <jianli@chromium.org>
Date: Tue Sep 04 23:49:38 2018

Show offline indicator via top snackbar

Per UX, we want to experiment with showing offline indicator via top
snackbar.
https://docs.google.com/presentation/d/1H8-H-XJS8Iw5WTPw_M62YrI52fVU3LiFBmww3UpYyeA/edit?ts=5b86dd3f#slide=id.g3d815b9766_0_103
(internal link)

Only one top snackbar can be shown at a time, independent of any
bottom snackbars.

Bug:  880486 
Change-Id: Iebfb977f2022feb7b6238b7865b2523a3c61113d
Reviewed-on: https://chromium-review.googlesource.com/1195895
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588696}
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[add] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java
[add] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarView.java
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/java_sources.gni
[modify] https://crrev.com/a0a9d41ab84b666e7f9fc4d83432e0b6e370b450/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java

Cc: nancygao@chromium.org
Labels: Merge-Request-70
Verified in Canary 71.0.3544.0
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 6

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 39 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge into 70, branch 3538.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/809d92d69115b8c433dfe7b94f0ba07f2d8d812b

commit 809d92d69115b8c433dfe7b94f0ba07f2d8d812b
Author: Jian Li <jianli@chromium.org>
Date: Fri Sep 07 20:32:37 2018

Merge M70: Show offline indicator via top snackbar

Per UX, we want to experiment with showing offline indicator via top
snackbar.
https://docs.google.com/presentation/d/1H8-H-XJS8Iw5WTPw_M62YrI52fVU3LiFBmww3UpYyeA/edit?ts=5b86dd3f#slide=id.g3d815b9766_0_103
(internal link)

Only one top snackbar can be shown at a time, independent of any
bottom snackbars.

TBR=jianli@chromium.org

(cherry picked from commit a0a9d41ab84b666e7f9fc4d83432e0b6e370b450)

Bug:  880486 
Change-Id: Iebfb977f2022feb7b6238b7865b2523a3c61113d
Reviewed-on: https://chromium-review.googlesource.com/1195895
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588696}
Reviewed-on: https://chromium-review.googlesource.com/1214089
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#155}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[add] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java
[add] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarView.java
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/java_sources.gni
[modify] https://crrev.com/809d92d69115b8c433dfe7b94f0ba07f2d8d812b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java

Status: Fixed (was: Started)

Sign in to add a comment