New issue
Advanced search Search tips

Issue 880484 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

generate_build_files failing on chromium.chrome/Google Chrome Win

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 4

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of huangs@chromium.org

generate_build_files failing on chromium.chrome/Google Chrome Win

Builders failed on: 
- Google Chrome Win: 
  https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win


 
Owner: grt@chromium.org
See
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/36622

Relevant messages:

""" to C:\b\c\b\win_chrome\src\out\Release\args.gn.
C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //chrome/installer/setup/google_chrome_behaviors.cc:30:11: Can't include this header from here.
#include "third_party/crashpad/crashpad/util/misc/uuid.h"
          ^---------------------------------------------
The target:
  //chrome/installer/setup:lib
is including a file from the target:
  //third_party/crashpad/crashpad/util:util
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //chrome/installer/setup:lib -->
  //components/crash/content/app:app --[private]-->
  //third_party/crashpad/crashpad/util:util

I'm reverting the CL. The fix should not be too hard but I don't want to rush this.
Hmm there's a merge conflict. Looking into fix.
Cc: grt@chromium.org nedngu...@google.com
 Issue 880488  has been merged into this issue.

Comment 5 Deleted

Merge conflict arises from:
https://chromium-review.googlesource.com/c/chromium/src/+/1200942

Behavior is reproed by
  gn gen out/Release --check


I tried to change setup/BUILD.gn to tweak
  "//third_party/crashpad/crashpad/client"

inclusion in various ways, but still see problem.

Cannot find quick fix, so going with double-revert:

(First) https://chromium-review.googlesource.com/c/chromium/src/+/1200942
(Then)  https://chromium-review.googlesource.com/c/chromium/src/+/1200862

(deleted comment #5 got order wrong).
Thanks Sam. That's the best course of action. I appreciate the quick response!
Cc: ligim...@chromium.org
 Issue 880490  has been merged into this issue.

Sign in to add a comment