generate_build_files failing on chromium.chrome/Google Chrome Win |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of huangs@chromium.org generate_build_files failing on chromium.chrome/Google Chrome Win Builders failed on: - Google Chrome Win: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win
,
Sep 4
I'm reverting the CL. The fix should not be too hard but I don't want to rush this.
,
Sep 4
Hmm there's a merge conflict. Looking into fix.
,
Sep 4
,
Sep 4
Merge conflict arises from: https://chromium-review.googlesource.com/c/chromium/src/+/1200942 Behavior is reproed by gn gen out/Release --check I tried to change setup/BUILD.gn to tweak "//third_party/crashpad/crashpad/client" inclusion in various ways, but still see problem. Cannot find quick fix, so going with double-revert: (First) https://chromium-review.googlesource.com/c/chromium/src/+/1200942 (Then) https://chromium-review.googlesource.com/c/chromium/src/+/1200862 (deleted comment #5 got order wrong).
,
Sep 4
Thanks Sam. That's the best course of action. I appreciate the quick response!
,
Sep 4
NP, everything's in now! Revert 1: https://chromium-review.googlesource.com/c/chromium/src/+/1204723 Revert 2: https://chromium-review.googlesource.com/c/chromium/src/+/1204725
,
Sep 4
|
||
►
Sign in to add a comment |
||
Comment 1 by hua...@chromium.org
, Sep 4