New issue
Advanced search Search tips

Issue 880474 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

"BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 4

Issue description

"BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygwELEgVGbGFrZSJ4QmlkaXJlY3Rpb25hbFN0cmVhbURlbGF5UmVxdWVzdEhlYWRlcnNVbnRpbEZsdXNoL0JpZGlyZWN0aW9uYWxTdHJlYW1UZXN0LlN0cmVhbUZhaWxCZWZvcmVSZWFkSXNFeGVjdXRlZE9uTmV0d29ya1RocmVhZC8wDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Detected 6 new flakes for test/step "BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygwELEgVGbGFrZSJ4QmlkaXJlY3Rpb25hbFN0cmVhbURlbGF5UmVxdWVzdEhlYWRlcnNVbnRpbEZsdXNoL0JpZGlyZWN0aW9uYWxTdHJlYW1UZXN0LlN0cmVhbUZhaWxCZWZvcmVSZWFkSXNFeGVjdXRlZE9uTmV0d29ya1RocmVhZC8wDA. This message was posted automatically by the chromium-try-flakes app.
 Issue 880475  has been merged into this issue.
Cc: pauljensen@chromium.org mef@chromium.org
Several of these on the fuchsia_x64 builder the last couple of hours:

Expected equality of these values:
  TestBidirectionalStreamCallback::ON_FAILED
    Which is: 7
  test.response_step
    Which is: 8

Examples:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/100948
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/100882
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/100864

Labels: OS-Fuchsia
Owner: mef@chromium.org
Status: Started (was: Untriaged)
I'll take a look.
I've created https://chromium-review.googlesource.com/c/chromium/src/+/1210364 to disable flaky test on Fuchsia while I investigate.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9960c2409bdbc2d025d0e9d08bea39e69c4d3b8

commit f9960c2409bdbc2d025d0e9d08bea39e69c4d3b8
Author: Misha Efimov <mef@chromium.org>
Date: Thu Sep 06 17:04:10 2018

[Cronet] Disable flaky BidirectionalStream test on fuchsia_x64 builder.

- The StreamFailBeforeReadIsExecutedOnNetworkThread is flaky on Fuchsia.

Bug:  880474 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I36c11741d674fec99286f25bd8503bb77903e950
Reviewed-on: https://chromium-review.googlesource.com/1210364
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589198}
[modify] https://crrev.com/f9960c2409bdbc2d025d0e9d08bea39e69c4d3b8/components/grpc_support/bidirectional_stream_unittest.cc

Detected 19 new flakes for test/step "BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygwELEgVGbGFrZSJ4QmlkaXJlY3Rpb25hbFN0cmVhbURlbGF5UmVxdWVzdEhlYWRlcnNVbnRpbEZsdXNoL0JpZGlyZWN0aW9uYWxTdHJlYW1UZXN0LlN0cmVhbUZhaWxCZWZvcmVSZWFkSXNFeGVjdXRlZE9uTmV0d29ya1RocmVhZC8wDA. This message was posted automatically by the chromium-try-flakes app.
mef: Looks like these tests were flaking even back in the original https://chromium-review.googlesource.com/c/chromium/src/+/1178666/14, suggesting that they are inherently flaky.

I think we should revert that CL and re-land once the tests are stable.
The test is disabled on fuchsia, so it shouldn't generate more flakes, and appears to be skipped as expected:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cronet_tests%20(with%20patch)&tests=BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/0

Confusingly, there are flaky BidirectionalStreamTest.* crashes reported on Mac, Win and Linux, but they are NOT caused by https://chromium-review.googlesource.com/c/chromium/src/+/1178666/ because there are exact same crashes in cronet_tests as in components_unittests, which have included BidirectionalStreamTest for over a year.

Detected 9 new flakes for test/step "BidirectionalStreamDelayRequestHeadersUntilFlush/BidirectionalStreamTest.StreamFailBeforeReadIsExecutedOnNetworkThread/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNygwELEgVGbGFrZSJ4QmlkaXJlY3Rpb25hbFN0cmVhbURlbGF5UmVxdWVzdEhlYWRlcnNVbnRpbEZsdXNoL0JpZGlyZWN0aW9uYWxTdHJlYW1UZXN0LlN0cmVhbUZhaWxCZWZvcmVSZWFkSXNFeGVjdXRlZE9uTmV0d29ya1RocmVhZC8xDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Removing from sheriff queue since test is disabled, thanks mef@ for investigating.
Components: -Tests>Flaky Internals>Network>Library
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Started)
Lowering priority and making available to fix and re-enable StreamFailBeforeReadIsExecutedOnNetworkThread.
Status: WontFix (was: Available)
Fuchsia is not planning to use Cronet.

Sign in to add a comment