New issue
Advanced search Search tips

Issue 880470 link

Starred by 1 user
Status: Fixed
Owner:
syoussefi@chromium.org
Closed: Sep 6
Cc:
pasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Rename BrowserSwitcherSitelist::ShouldRedirect()

Project Member Reported by nicolaso@chromium.org, Sep 4 
The name is confusing, and clashes with HTTP redirects...

We could rename to something like SouldSwitch().

Comment 1 by syoussefi@chromium.org, Sep 4

Owner: syoussefi@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c0d4ec3c2291d437db4afd8af7b28ecc9632086

commit 1c0d4ec3c2291d437db4afd8af7b28ecc9632086
Author: Shahbaz Youssefi <syoussefi@chromium.org>
Date: Thu Sep 06 20:59:11 2018

Rename BrowserSwitcherSitelist::ShouldRedirect()

The new name is ShouldSwitch, to avoid confusion with http's redirect.

Bug:  880470 
Change-Id: Ia25c476a75fb90b1e919df7c114d923da3d688d9
Reviewed-on: https://chromium-review.googlesource.com/1205480
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589295}
[modify] https://crrev.com/1c0d4ec3c2291d437db4afd8af7b28ecc9632086/chrome/browser/browser_switcher/browser_switcher_sitelist.cc
[modify] https://crrev.com/1c0d4ec3c2291d437db4afd8af7b28ecc9632086/chrome/browser/browser_switcher/browser_switcher_sitelist.h
[modify] https://crrev.com/1c0d4ec3c2291d437db4afd8af7b28ecc9632086/chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc

Comment 3 by syoussefi@chromium.org, Sep 6

Status: Fixed (was: Untriaged)
►

Sign in to add a comment