New issue
Advanced search Search tips

Issue 880462 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[remoting WebRTC] Use TURN-provided relay cap

Project Member Reported by lambroslambrou@chromium.org, Sep 4

Issue description

The Google TURN servers now provide a recommended bitrate cap in the ICE config response.
The host currently sets a hardcoded value of 8000Kbps. The host should instead use the value from the ICE config response.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0

commit f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Fri Sep 07 00:04:09 2018

[remoting WebRTC] Use maxRateKbps from ICE config

This replaces the hard-coded relay bandwidth cap of 8000Kbps with
the value of maxRateKbps (if present) in the ICE config response from
the TURN server. If the value is not present, no cap is applied.

Bug:  880462 
Change-Id: I0d8d2a48f78559e93cff94055a65da7ec32de494
Reviewed-on: https://chromium-review.googlesource.com/1211668
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589376}
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/ice_config.cc
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/ice_config.h
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/ice_config_unittest.cc
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/transport_context.cc
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/transport_context.h
[modify] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/remoting/protocol/webrtc_transport.cc

Components: Services>Chromoting
Labels: Merge-Request-70
Status: Assigned (was: Started)
Requesting merge of revision f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0 onto M70.

This is a simple change to the remoting host process, and doesn't affect Chrome browser. Fix verified on Official build 71.0.3545.3.

Project Member

Comment 3 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1

commit ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Mon Sep 10 21:43:02 2018

[remoting WebRTC] Use maxRateKbps from ICE config

This replaces the hard-coded relay bandwidth cap of 8000Kbps with
the value of maxRateKbps (if present) in the ICE config response from
the TURN server. If the value is not present, no cap is applied.

Bug:  880462 
Change-Id: I0d8d2a48f78559e93cff94055a65da7ec32de494
Reviewed-on: https://chromium-review.googlesource.com/1211668
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589376}(cherry picked from commit f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0)
Reviewed-on: https://chromium-review.googlesource.com/1217451
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#252}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/ice_config.cc
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/ice_config.h
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/ice_config_unittest.cc
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/transport_context.cc
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/transport_context.h
[modify] https://crrev.com/ce6c3498b4b2faad39c278a74933c0e4cf1f0fc1/remoting/protocol/webrtc_transport.cc

Status: Fixed (was: Assigned)

Sign in to add a comment