New issue
Advanced search Search tips

Issue 880459 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

StartContainer RPC timeout on Braswell boards

Project Member Reported by jkardatzke@google.com, Sep 4

Issue description

We currently have a 30 second timeout for the StartContainer call which has been more than enough for existing boards. Some of the slower Braswell boards end up hitting this timeout, so it should be increased.
 
Cc: smbar...@chromium.org
Owner: jkardatzke@chromium.org
Status: Started (was: Untriaged)
Status: Fixed (was: Started)
(Fix was done w/out a bug originally, so I'm pasting this in myself)

vm_tools: cicerone: Increase StartLxdContainer timeout

Increase from 30 to 60 seconds to allow for longer first time container
startup on Braswell boards.

BUG=None
TEST=Builds

Change-Id: I123ea8efeffa5dae8d1a63c6869b0cd16c758f7d
Reviewed-on: https://chromium-review.googlesource.com/1196835
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
---
M vm_tools/cicerone/virtual_machine.cc
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/vm_tools/cicerone/virtual_machine.cc b/vm_tools/cicerone/virtual_machine.cc
index 90c81b2..3e3f401 100644
--- a/vm_tools/cicerone/virtual_machine.cc
+++ b/vm_tools/cicerone/virtual_machine.cc
@@ -37,8 +37,9 @@
 // How long to wait while creating a container.
 constexpr int64_t kCreateLxdContainerTimeoutSeconds = 30;
 
-// How long to wait while starting a container.
-constexpr int64_t kStartLxdContainerTimeoutSeconds = 30;
+// How long to wait while starting a container. This can take over 30 seconds on
+// Braswell boards when starting it for the first time.
+constexpr int64_t kStartLxdContainerTimeoutSeconds = 60;
 
 }  // namespace
 
Labels: Merge-Request-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 5

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70 Merge-Merged M-70

Sign in to add a comment