Add WPR archive health metric |
||||
Issue descriptionThe new metric should track the number of errors that occur during a benchmark run. Doc: https://docs.google.com/document/d/1YLxqDKNu-UWY9b0_rHbL6g0qXKZk9Fq2VFUb9LLRNec/edit?usp=sharing A simple solution is to add a TRACE_EVENT for DevTools console errors. This would catch network errors and application errors. Once we have the trace event, the metric can be implemented as an ordinary tracing metric that inspects the trace file. Details: - Extend the existing “blink.console” category with “Console.Error” events TRACE_EVENT1("blink.console", "ConsoleError", message) or TRACE_EVENT1("blink.console", "ConsoleError", source) - Network errors are reported in ConsoleMessageStorage::AddConsoleMessage. - V8 sends JavaScript console errors directly to DevTools frontend. We can intercept them in V8ConsoleMessageStorage::addMessage. Note that TRACE_EVENT there would have to use “blink.console” category even though it will be called in V8. Alternative would be to add a new category “console”. - Add a console_error_count metric to catapult/tracing/tracing/metrics/console_metric.html
,
Sep 4
> Can devtool folks vet this idea as well since we are relying on your trace event? I added Alexey and Yang to the doc to get DevTools perspective on this.
,
Sep 5
Telemetry has full access to all console messages over the protocol. Why the trace event?
,
Sep 5
Under which category are they exposed? We've enabled blink.console + devtools categories and didn't see the console.error messages in the raw trace file.
,
Sep 5
I think using the trace event has the benefit that the error is lined up with other Chrome traces in trace viewer UI, making it's easier to debug
,
Sep 5
Two reasons: 1) We don't want to change performance and memory profile of the benchmarks by enabling console. Some web pages log a lot of non-error stuff in console, and console keeps objects alive. 2) Telemetry metrics work on the trace file offline. Without trace event, we would have to find a way to inject artificial event into the trace file from python runner script. This will add a lot of code complexity compared to one line trace event.
,
Sep 5
Ulan, Runtime domain is responsible for console messages and keeping objects alive, it is indeed enabled in the telemetry. You won't change and of the performance or memory characteristics. But I get the ergonomics of the trace event given that you need to consider it in the context of the trace though. So I no longer have concerns regarding adding it. It hurts to see loosely-typed trace events scattered over the source base now in v8 as well. That's a technical debt we are seeding with our own hands. If all you needed was to get a list of errors with locations from the test run, I would recommend relying upon protocol instead.
,
Sep 5
After re-reading the bug definition, still have questions. - The bug suggests adding "console_error_count", which implies all you need is to count them. You can do that today w/o trace event, using typed API. - The bug suggests you catch network errors with it, but you don't - The trace event that you add in the CL has no source information other than a type, it will always be JSMessageSource. there must be some kind of confusion.
,
Sep 5
I'm confused. This bug mentions the V8ConsoleMessageStorage::addMessage, my comments regarding the console message type imply you are intercepting it as stated in this bug. But the patch I saw was changing blink and not touching V8ConsoleMessage. Are there two different patches?
,
Sep 5
Thanks, Pavel. I didn't know that console messages are already enabled in telemetry. In that case it is worthwhile exploring the protocol approach. I will look into this. Re comment #8: There are two trace event CLs: one in V8 for JS error messages and one in blink for Chrome error messages including network messages: - https://chromium-review.googlesource.com/c/v8/v8/+/1204570 - https://chromium-review.googlesource.com/c/chromium/src/+/1203957 Here is CL that defines the metric: https://chromium-review.googlesource.com/c/catapult/+/1205170 > You can do that today w/o trace event, using typed API. That sounds great. I am not familiar with typed API. Could you please point me to a doc or source code?
,
Sep 5
Ok, I think we are now getting closer to understanding each other's pov. - There are no generic 'console messages', console is a place in the DevTools UI, that's it. - Telemetry enables Runtime domain, this makes them receive all the console.* calls and unhandled exceptions. These are available with locations, stacks and are very much actionable (unlike the trace events you add that are very bare). - I'm not sure whether Telemetry enables the Log domain, if it does not, it should call "Log.enable". This gives them all kinds of generic errors, again with the locations and actionable information. Enabling Log domain does not carry performance overhead. - The typed API I'm referring to is the remote debug protocol. Specifically, Runtime and Log domains. Again, stray trace event is not a big deal, you can add it. But that somewhat adds into the techdebt of our systems. You can see how the places you add them into are working, but are very much arbitrary...
,
Sep 5
Thank you for helping with this! I agree that the remote debug protocol approach would be preferable if we can make the metrics code work in Telemetry. I'll experiment with it and update the bug.
,
Sep 6
I have a prototype of using Log domain in Telemetry: https://chromium-review.googlesource.com/c/catapult/+/1210222 Good news: adding support for Log domain was easy. Bad news: collecting log entries from multiple browser tabs and propagating them to the place where we generate the trace file breaks Telemetry abstractions. At this point the trace event approach seems better.
,
Sep 6
+1 to Ulan@'s assessment. The Telemetry's modern benchmark architecture separate the application under test (browser in this case) from the measurement/metrics code. Trace is the only vessel for transferring data from application to the metric code for simplicity. Hence if we go with the approach with using devtool Log, we will need to find a way to augment the log domain's output into the trace that gets passed to Measure() method in Telemetry, which is non trivial itself, imo. Though I think Pavel's point about this trace event aren't meant to be a stable API is valid. For P1, can we use these trace events, then implement other trace points that are meant to be more stable?
,
Sep 6
I updated the CL to remove coupling between V8 and Chromium, now they can be changed independently. There is still coupling between Chromium/V8 and the metric code. So a change in Chromium or V8 can break the metric, but this is an inherent problem for all metrics that we have.
,
Sep 6
Sounds good. This sort-of locks benchmarking into the Tracing, which I'm not sure whether is a good or bad thing. Having everything at one place it good, but trace events are bad. Maybe perfetto improves things...
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/206d37b926f8e68b427f4f1b53aedb1e07bb8a1b commit 206d37b926f8e68b427f4f1b53aedb1e07bb8a1b Author: Ulan Degenbaev <ulan@chromium.org> Date: Fri Sep 07 10:48:36 2018 Emit trace event on console error messages from JS. This is needed to implement a new metric that measures health of Web Page Replay archives. Bug: chromium:880432 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59aed22e4671e491fc3a30d04fbdce1643404b32 Reviewed-on: https://chromium-review.googlesource.com/1204570 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55716} [modify] https://crrev.com/206d37b926f8e68b427f4f1b53aedb1e07bb8a1b/src/inspector/v8-console-message.cc
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/106d366ce33fc7ee0d9160526855d26bf15b360e commit 106d366ce33fc7ee0d9160526855d26bf15b360e Author: Ulan Degenbaev <ulan@chromium.org> Date: Fri Sep 07 11:27:43 2018 Add a metric that tracks the number of console error messages - console:error:all for all console error messages. - console:error:js for console error messages coming from JS. - console:error:network for console error messages coming from network. Bug: chromium:880432 Change-Id: Icbc82350f722494550310fec83bdfe150ce14e81 Reviewed-on: https://chromium-review.googlesource.com/1205170 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/106d366ce33fc7ee0d9160526855d26bf15b360e/BUILD.gn [add] https://crrev.com/106d366ce33fc7ee0d9160526855d26bf15b360e/tracing/tracing/metrics/console_error_metric.html [add] https://crrev.com/106d366ce33fc7ee0d9160526855d26bf15b360e/tracing/tracing/metrics/console_error_metric_unittest.html [modify] https://crrev.com/106d366ce33fc7ee0d9160526855d26bf15b360e/tracing/tracing/metrics/all_metrics.html [modify] https://crrev.com/106d366ce33fc7ee0d9160526855d26bf15b360e/tracing/trace_viewer.gypi
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2 commit 79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Sep 07 18:49:21 2018 Roll src/third_party/catapult bcc3e491fb2e..32654a45d3da (16 commits) https://chromium.googlesource.com/catapult.git/+log/bcc3e491fb2e..32654a45d3da git log bcc3e491fb2e..32654a45d3da --date=short --no-merges --format='%ad %ae %s' 2018-09-07 nednguyen@google.com Remove common/battor/ 2018-09-07 simonhatch@chromium.org Dashboard - Simplify find_anomalies by removing benchmark_duration 2018-09-07 simonhatch@chromium.org Dashboard - Generate stats on alert #'s 2018-09-07 nednguyen@google.com Fix BUILD.gn by running generate_telemetry_build.py 2018-09-07 ulan@chromium.org Add a metric that tracks the number of console error messages 2018-09-07 wangge@google.com Reformat the `run_benchmark` help message. 2018-09-06 benjhayden@chromium.org Fix flaky dashboard tests: timeseries2_test, file_bug_test, others. 2018-09-06 wangge@google.com Update help message for `run_benchmark.py`. 2018-09-06 benjhayden@chromium.org dashboard/bin/run_wct_tests 2018-09-06 nastasoiuf@google.com Stacked bar plot integration 2018-09-06 simonhatch@chromium.org Dashboard - Fix stats generation for chrome health metrics 2018-09-06 rmcilroy@chromium.org [Tracing] Add support for Optimize-Background bucket to V8's runtime call stats table 2018-09-06 anthonyalridge@google.com Add back bar chart interaction 2018-09-06 mattm@chromium.org netlog_viewer: rename |global| in cr.js to |cr_global| 2018-09-05 mattm@chromium.org netlog_viewer: Apply chromium changes up to 940b87bb7cb870e5d441 2018-09-05 jbudorick@chromium.org Fix systrace/bin/OWNERS. Created with: gclient setdep -r src/third_party/catapult@32654a45d3da The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:881543 , chromium:881379 , chromium:881361 , chromium:881543 ,chromium:880432, chromium:863390 , chromium:877660 ,chromium:866423,chromium:879229,chromium:866423 TBR=sullivan@chromium.org Change-Id: I2206a43b38a09c7427d4d4ef02fe4c820dbaee98 Reviewed-on: https://chromium-review.googlesource.com/1213476 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589610} [modify] https://crrev.com/79f8b4dcb67bf6bcc2f26bbae15746b90458d0c2/DEPS
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18b8d9c41b917c7b6a44a67d7e927db10b7ee919 commit 18b8d9c41b917c7b6a44a67d7e927db10b7ee919 Author: Ulan Degenbaev <ulan@chromium.org> Date: Sat Sep 08 18:00:44 2018 Emit trace event on console error messages. This is needed to implement a new metric that measures health of Web Page Replay archives. Bug: 880432 Change-Id: I8d3e7d83c9dc7b59ddc9953b5d4f0e1c5a707fcb Reviewed-on: https://chromium-review.googlesource.com/1203957 Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589786} [modify] https://crrev.com/18b8d9c41b917c7b6a44a67d7e927db10b7ee919/chrome/test/chromedriver/test/run_py_tests.py [modify] https://crrev.com/18b8d9c41b917c7b6a44a67d7e927db10b7ee919/third_party/blink/renderer/core/inspector/console_message_storage.cc
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0c8cc6141c626e0ca419877ff5bbf6052a9876f2 commit 0c8cc6141c626e0ca419877ff5bbf6052a9876f2 Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Sep 10 11:37:25 2018 Fix a bug in console error metric. Events from V8 do not have the source argument anymore. Bug: chromium:880432 Tbr: benjhayden@chromium.org Change-Id: I9bf23ef102e0b02f4e5631a58325549492d2f47f Reviewed-on: https://chromium-review.googlesource.com/1215628 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> [modify] https://crrev.com/0c8cc6141c626e0ca419877ff5bbf6052a9876f2/tracing/tracing/metrics/console_error_metric.html
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fac9c1f419b2da00fd5962ad2d85b155dc2680c0 commit fac9c1f419b2da00fd5962ad2d85b155dc2680c0 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Sep 10 14:14:16 2018 Roll src/third_party/catapult 234d4e4d5de2..0c8cc6141c62 (1 commits) https://chromium.googlesource.com/catapult.git/+log/234d4e4d5de2..0c8cc6141c62 git log 234d4e4d5de2..0c8cc6141c62 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 ulan@chromium.org Fix a bug in console error metric. Created with: gclient setdep -r src/third_party/catapult@0c8cc6141c62 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880432 TBR=sullivan@chromium.org Change-Id: Ifab689590bc91edb6e04ce0517fbb8df7769da53 Reviewed-on: https://chromium-review.googlesource.com/1216103 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589901} [modify] https://crrev.com/fac9c1f419b2da00fd5962ad2d85b155dc2680c0/DEPS
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/800a5c5f932161dac270f996bed6691ff38f0d43 commit 800a5c5f932161dac270f996bed6691ff38f0d43 Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Sep 11 07:52:48 2018 Enable console error metric for system health and v8 browsing benchmarks Bug: 880432 Change-Id: Ice70a3804321e89f21579436e2de05a76cdeb8fd Reviewed-on: https://chromium-review.googlesource.com/1216283 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#590227} [modify] https://crrev.com/800a5c5f932161dac270f996bed6691ff38f0d43/tools/perf/benchmarks/system_health.py [modify] https://crrev.com/800a5c5f932161dac270f996bed6691ff38f0d43/tools/perf/benchmarks/v8_browsing.py
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a commit 1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a Author: Ulan Degenbaev <ulan@chromium.org> Date: Thu Sep 13 11:23:02 2018 Output DevTools error messages as warnings while running a story. Bug: chromium:880432 Change-Id: I2367a17d3ea1739a015ccb381479ad12eb1ae831 Reviewed-on: https://chromium-review.googlesource.com/1220366 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> [add] https://crrev.com/1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_log.py [modify] https://crrev.com/1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e40ef3866f085d2c6b25183968531edcb85e05c commit 7e40ef3866f085d2c6b25183968531edcb85e05c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Sep 13 14:41:38 2018 Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits) https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..c4d326feb2ff git log 3e071665b9f9..c4d326feb2ff --date=short --no-merges --format='%ad %ae %s' 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label. 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it. 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter. 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story. Created with: gclient setdep -r src/third_party/catapult@c4d326feb2ff The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432 TBR=sullivan@chromium.org Change-Id: I68916abd79b995d8c990f4fc64c65dce5cdbaa23 Reviewed-on: https://chromium-review.googlesource.com/1224473 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591005} [modify] https://crrev.com/7e40ef3866f085d2c6b25183968531edcb85e05c/DEPS
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/393391985b970fe0f33952d108f2470c8d1fdb83 commit 393391985b970fe0f33952d108f2470c8d1fdb83 Author: Darren Shen <shend@chromium.org> Date: Fri Sep 14 02:00:31 2018 Revert "Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits)" This reverts commit 7e40ef3866f085d2c6b25183968531edcb85e05c. Reason for revert: 883892 Original change's description: > Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits) > > https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..c4d326feb2ff > > > git log 3e071665b9f9..c4d326feb2ff --date=short --no-merges --format='%ad %ae %s' > 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label. > 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it. > 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark > 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter. > 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story. > > > Created with: > gclient setdep -r src/third_party/catapult@c4d326feb2ff > > The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > BUG=chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432 > TBR=sullivan@chromium.org > > Change-Id: I68916abd79b995d8c990f4fc64c65dce5cdbaa23 > Reviewed-on: https://chromium-review.googlesource.com/1224473 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#591005} TBR=sullivan@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Iacf4973a98666f6030cb3373629cefdfc58f95e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866423, chromium:863390 , chromium:883322 , chromium:880432 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1226534 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#591261} [modify] https://crrev.com/393391985b970fe0f33952d108f2470c8d1fdb83/DEPS
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/79d6b805c023a98e83689beb3d0ae9de63881f85 commit 79d6b805c023a98e83689beb3d0ae9de63881f85 Author: Ulan Degenbaev <ulan@chromium.org> Date: Fri Sep 14 09:19:00 2018 Revert "Output DevTools error messages as warnings while running a story." This reverts commit 1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a. Reason for revert: blocking roll Bug: chromium:883892 Original change's description: > Output DevTools error messages as warnings while running a story. > > Bug: chromium:880432 > Change-Id: I2367a17d3ea1739a015ccb381479ad12eb1ae831 > Reviewed-on: https://chromium-review.googlesource.com/1220366 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> TBR=ulan@chromium.org,perezju@chromium.org,nednguyen@google.com,cbruni@chromium.org Change-Id: I1c8d91564f7def004fa942b906f88076f1100c12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:880432 Reviewed-on: https://chromium-review.googlesource.com/1225894 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> [delete] https://crrev.com/5d54982d7abcc9d602ac4cc4decf214065c387f0/telemetry/telemetry/internal/backends/chrome_inspector/inspector_log.py [modify] https://crrev.com/79d6b805c023a98e83689beb3d0ae9de63881f85/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35 commit 8323f92cb0c81332c00abfe5a3bad012a400fd35 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Sep 14 16:52:21 2018 Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits) https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813 git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle 2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story." 2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads 2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws. 2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner 2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug 2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions 2018-09-13 pasko@chromium.org clear_system_cache: update binaries 2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG. 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label. 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it. 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter. 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story. Created with: gclient setdep -r src/third_party/catapult@9f36d9f78813 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432 TBR=sullivan@chromium.org Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861 Reviewed-on: https://chromium-review.googlesource.com/1226380 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591375} [modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a193ad34dd646589dbfe0d4c610b2d08e68449fd commit a193ad34dd646589dbfe0d4c610b2d08e68449fd Author: Camillo Bruni <cbruni@chromium.org> Date: Thu Sep 20 08:46:56 2018 Reland: Output DevTools error messages as warnings while running a story. The original CL https://crrev.com/c/1220366 did not support 'url' being an option argument as specified by the DevTools protocol: https://chromedevtools.github.io/devtools-protocol/1-3/Log#type-LogEntry Bug: chromium:880432 Change-Id: Ibb01d3de23134c452bf6eaa8cdd560cb580a0503 Reviewed-on: https://chromium-review.googlesource.com/1233338 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> [add] https://crrev.com/a193ad34dd646589dbfe0d4c610b2d08e68449fd/telemetry/telemetry/internal/backends/chrome_inspector/inspector_log.py [modify] https://crrev.com/a193ad34dd646589dbfe0d4c610b2d08e68449fd/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9f509ccf4a8eaf218084d0208586b363a382f6c commit c9f509ccf4a8eaf218084d0208586b363a382f6c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Sep 20 10:37:41 2018 Roll src/third_party/catapult 582a06eb7835..8495ffe55979 (3 commits) https://chromium.googlesource.com/catapult.git/+log/582a06eb7835..8495ffe55979 git log 582a06eb7835..8495ffe55979 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 wangge@google.com Add function to collect the results after all the jobs have started. 2018-09-20 cbruni@chromium.org Reland: Output DevTools error messages as warnings while running a story. 2018-09-20 wangge@google.com Add utility functions to add new target. Created with: gclient setdep -r src/third_party/catapult@8495ffe55979 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:863390 ,chromium:880432, chromium:863390 TBR=sullivan@chromium.org Change-Id: Id6330948993bd8ecc83097ad61ca9e8726f110f0 Reviewed-on: https://chromium-review.googlesource.com/1235834 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592748} [modify] https://crrev.com/c9f509ccf4a8eaf218084d0208586b363a382f6c/DEPS
,
Sep 20
Seem like there is no regression with adding the console dev metrics. Can we enable devtool console metrics for all the TBMv2 metrics now? :-)
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/e5495aef8e462d6aa5f4460afea10d5b90338543 commit e5495aef8e462d6aa5f4460afea10d5b90338543 Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Sep 25 10:12:14 2018 Add v8.console to the default categories. Bug: chromium:880432 Change-Id: I43bd2741625d6e4c58db044bf683126040b57f37 Reviewed-on: https://chromium-review.googlesource.com/1216322 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/e5495aef8e462d6aa5f4460afea10d5b90338543/telemetry/telemetry/web_perf/timeline_based_measurement.py
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52982fc80084dc8b2108b8f6235e088c8c34c95c commit 52982fc80084dc8b2108b8f6235e088c8c34c95c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Sep 25 12:18:30 2018 Roll src/third_party/catapult 7931f7f4ae38..e5495aef8e46 (2 commits) https://chromium.googlesource.com/catapult.git/+log/7931f7f4ae38..e5495aef8e46 git log 7931f7f4ae38..e5495aef8e46 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 ulan@chromium.org Add v8.console to the default categories. 2018-09-25 nednguyen@google.com Remove legacy startup TBMv1 metrics Created with: gclient setdep -r src/third_party/catapult@e5495aef8e46 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880432,chromium:760498 TBR=sullivan@chromium.org Change-Id: Iafe7bf75a6b75abba5885eef2aafbc9e207cba6b Reviewed-on: https://chromium-review.googlesource.com/1242326 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593898} [modify] https://crrev.com/52982fc80084dc8b2108b8f6235e088c8c34c95c/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nednguyen@chromium.org
, Sep 4