New issue
Advanced search Search tips

Issue 880372 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Page crashes when modifying a non-breaking space

Reported by molli.be...@gmail.com, Sep 4

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Have a non-breaking space between two elements.
2. Edit the page and replace the non-breaking space by a normal space.
3. Go into edit html mode (only clicking on the space) and delete it two times. The second time it is deleted the page will crash altogether and has to be reloaded.

What is the expected behavior?

What went wrong?
DevTools seemingly doesn't recognize the first delete correctly; the space should already be deleted at that point but is still displayed in DevTools. So the second delete causes unexpected stuff to happen.

Did this work before? N/A 

Chrome version: 68.0.3440.106  Channel: stable
OS Version: 10.0
Flash Version:
 
chrome devtools crash.html
124 bytes View Download
Labels: Needs-Milestone
Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback
molli.bender@ Thanks for the issue.

Tested this issue on Windows 10 on the reported version 68.0.3440.106 and the latest Canary 71.0.3543.0 and unable to reproduce the issue by following the below steps.

1. Launched Chrome and navigated to the given html page.
2. Opened Devtools and tried to delete the non-breaking space and added a normal space.
3. Couldn't observe any crash on the webpage.

Request you to provide the Crash ID from chrome://crashes, which will help in further triaging of the issue.

Also request you to retry the issue by updating chrome to the latest Stable 69.0.3497.81 and update the thread with the observations.

Thanks..
I just updated chrome to the latest version (69.0.3497.81) and I can still reproduce this problem. Crash id of one of the crashes: 73b34f80-5ac9-4223-ada1-a174a2fda4b7

I attached a video showing exactly what I did to get this issue to occur.
Chrome devtools crash.mp4
2.3 MB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 5

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Triage-M69
Cc: swarnasree.mukkala@chromium.org
Labels: TE-NeedsTriageFromHYD
molli.bender@: Thanks for providing Crash ID.

As per comment#3, the reporter has provided Crash ID, hence routing this issue to Inhouse for further triaging the issue and adding TE-NeedsTriageFromHYD label to it.

Thanks!
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Thanks for the reply molli.bender@.

Unable to reproduce the issue on Windows 10 using chrome-69.0.3497.81 as per the screencast provided in C#3.

Could you provide us the latest 16 digit crash server id from chrome://crashes(as attached in screenshot) to proceed further triaging.

Note: Local crash id is not enough to get info from crash server.

880372-Win-69.0.3497.81.mp4
1.8 MB View Download
Latest server crash is the following: ed9cee1e8b6cc993

jmukthavaram@
Watching your video I noticed that you didn't replace the " " in the code with a normal space when editing, which doesn't result in a crash. The text between the two html elements (in this case the non-breaking space) has to be replaced with a normal space first.
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 7

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Components: Blink>Editing
Components: -Blink>Editing
There's nothing to do with Blink editing.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/367f7e992a7a3581caabca95ce66336d21dccdf9

commit 367f7e992a7a3581caabca95ce66336d21dccdf9
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Oct 04 00:32:09 2018

DevTools: Don't crash when text nodes are edited to be whitespace

DevTools ignores whitespace-only text nodes. But if a text node
that previously had text becomes whitespace-only, no childNodeRemoved
event is fired and DevTools would get confused.

Bug:  880372 
Change-Id: I8f740a6e32d1c1a15a32443a2a702996028f64fa
Reviewed-on: https://chromium-review.googlesource.com/c/1257899
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596443}
[modify] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-2-expected.txt
[add] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-whitespace-expected.txt
[add] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/set-outer-html-whitespace.js
[modify] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/WebKit/LayoutTests/http/tests/devtools/elements/highlight/highlight-dom-updates-expected.txt
[modify] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/367f7e992a7a3581caabca95ce66336d21dccdf9/third_party/blink/renderer/core/inspector/inspector_dom_agent.h

Status: Fixed (was: Assigned)
Sorry if I am missing something very obvious, but I still see this issue happening for me. I believe this is supposed to be fixed though?
I guess nevermind, this bug was fixed in the current version 71.0.3578.80.

Sign in to add a comment