New issue
Advanced search Search tips

Issue 880344 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: ----



Sign in to add a comment

core.stacktrace_unittest.TabStackTraceTest.testCrashSymbols in telemetry_perf_unittests failing on chromium.mac/Mac10.12 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 4

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of huangs@chromium.org

(Edited: This focuses on "Failure sizes", not telemetry_perf_unittests as seen in title).

Builders failed on: 
- mac-rel
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/503

Cause:
https://chromium-review.googlesource.com/c/chromium/src/+/1193884
per_user_topic_invalidation_client.cc
- static initializer used for std::string private_topic_name_prefix.


 
Description: Show this description
Labels: OS-Mac
Owner: melandory@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a6dd62b8ff79d9271b0b71289eabb61e1b44c9e

commit 2a6dd62b8ff79d9271b0b71289eabb61e1b44c9e
Author: Tanja Gornak <melandory@chromium.org>
Date: Tue Sep 04 16:37:49 2018

[Tango->FCM] Remove static initializer from invalidation client

Bug:  879571 , 801985,  880344 
TBR=pavely@chromium.org

Change-Id: I224e704c348d031e68e7341122331015d20e9f61
Reviewed-on: https://chromium-review.googlesource.com/1204017
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588543}
[modify] https://crrev.com/2a6dd62b8ff79d9271b0b71289eabb61e1b44c9e/components/invalidation/impl/per_user_topic_invalidation_client.cc

Labels: -Sheriff-Chromium
Status: Fixed (was: Available)
Looks fixed. 

Please re-add the Sheriff-Chromium label in case this is re-opened.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a627cd0a1ee2e6e1d756eeb1c92eeeed15d3d9e

commit 1a627cd0a1ee2e6e1d756eeb1c92eeeed15d3d9e
Author: Tanja Gornak <melandory@chromium.org>
Date: Tue Sep 11 22:55:08 2018

[Tango->FCM] Remove static initializer from invalidation client

Bug:  879571 , 801985,  880344 
TBR=melandory@chromium.org, pavely@chromium.org

(cherry picked from commit 2a6dd62b8ff79d9271b0b71289eabb61e1b44c9e)

Change-Id: I224e704c348d031e68e7341122331015d20e9f61
Reviewed-on: https://chromium-review.googlesource.com/1204017
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588543}
Reviewed-on: https://chromium-review.googlesource.com/1220148
Cr-Commit-Position: refs/branch-heads/3538@{#303}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1a627cd0a1ee2e6e1d756eeb1c92eeeed15d3d9e/components/invalidation/impl/per_user_topic_invalidation_client.cc

Sign in to add a comment