New issue
Advanced search Search tips

Issue 880338 link

Starred by 1 user
Status: Closed
Owner:
herb@google.com
Closed: Sep 4
Cc:
maxlg@chromium.org
herb@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.2%-71.9% regression in rendering.desktop at 587297:587402

Project Member Reported by maxlg@chromium.org, Sep 4 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 4 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=880338

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=dc1f1bc5a1f04a10edc6a4dd39d884b29968059f7f7591b1f42bbbaf94315f1e


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf
android-nexus5x-perf
mac-10_12_laptop_low_end-perf
mac-10_13_laptop_high_end-perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks

rendering.desktop - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 4

Cc: herb@google.com
Owner: herb@google.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/179404cd640000

Managing the context was dropped. Adding back in. by herb@google.com
https://skia.googlesource.com/skia/+/aca2b9eebdaf5ec45ba87a25c60510988fc54756
1.007 → 1.543 (+0.5358)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by herb@google.com, Sep 4

Status: Closed (was: Assigned)
Some cache management code was accidentally removed in cl
https://skia-review.googlesource.com/c/skia/+/149041

This is adding back, and this works as intended.
►

Sign in to add a comment