App crashes on opening a new tab from 3D force touch in landscape mode. |
|||||
Issue descriptionApp Version: 71.0.3542.0 canary iOS Version: iOS 10.3.3, 11.4 Device: iPhone,iPad Steps to reproduce: 1. Launch Chrome in landscape mode. 2. Tap on tabswithcer. 3. Scroll to recent tabs screen. 4. Tap on Show full history > Tap on Search 5. Long tap on any url. 6. Send the app to background. 7. Open new tab from 3D force touch or from todays view 8. Tap on Cancel in History screen Observed results: App crashes Note : Issue is seen when opening history from tab grid view Expected results: App should not crash Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : No in M68 Bug reproducible on the current beta channel build : Yes in M69 Link to video/image: https://drive.google.com/file/d/1mfQu_Yj8RtJdHJV_qDN73W7nYW4w4qEZ/view?usp=sharing Crash log : https://docs.google.com/document/d/1sAzJGKV09jpv3H9HFHJhChHM3l17wYjzjnvQXXCBfMY/edit?usp=sharing
,
Sep 11
,
Sep 27
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f commit 7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f Author: sczs <sczs@chromium.org> Date: Tue Oct 09 17:18:16 2018 [ios] Stops ContextMenuCoordinator when dismissing History. - Stops ContextMenuCoordinator when dismissing History, in order to this the ContextMenuCoordinator is now exposed to the HistoryCoordinator. - HistoryNavigationController now presents the ContextMenuCoordinator. Bug: 880260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7ad88abf1edb6853160a63276dbceb5bb4863c36 Reviewed-on: https://chromium-review.googlesource.com/c/1269627 Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#597965} [modify] https://crrev.com/7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f/ios/chrome/browser/ui/history/history_coordinator.mm [modify] https://crrev.com/7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f/ios/chrome/browser/ui/history/history_table_view_controller.h [modify] https://crrev.com/7d1744915d6cd9a9b1729b1865b0c5eaa72cdc7f/ios/chrome/browser/ui/history/history_table_view_controller.mm
,
Oct 9
,
Oct 16
Verified in 72.0.3582.0 Canary in iPhone 8plus(iOS 11.4.2), iPhone 6s plus(iOS 12.1 beta) Followed the steps from comment#0, at step 5, the context menu pops up by dismissing the focus on history search which means rest of the steps is not possible to follow Also Tested on opening new tab with 3D force touch with context menu displayed. App doesn't crash looks good. Link to video: https://drive.google.com/file/d/1U5AuDfjVWZkfMJERV_gJ1m0HyrRdM7st/view?usp=sharing
,
Oct 17
Verified the issue on the build tested on the version 71.0.3578.8 beta tested on iPhone 7+(iOS 12). App doesn't crashes with the above steps works fine. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by justincohen@chromium.org
, Sep 5Components: UI>Browser>NewTabPage
Labels: ReleaseBlock-Stable M-71
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)