Issue metadata
Sign in to add a comment
|
Regression: Wrong context menu is seen for apps on chrome://apps page.
Reported by
db...@etouch.net,
Sep 4
|
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3542.0 Revision 4097c6595e73c799040bc3a99bcfcc6adb178386-refs/branch-heads/3542@{#1}(64 bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14). What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://apps page. (2) Right click on any app and observe context menu. Actual: Wrong context menu is seen for apps on chrome://apps page. Expected: Context menu should seen properly. This is a regression issue, broken in 'M71', will soon update the other info: Good Build:70.0.3538.0 (Revision:587812) Bad Build: 71.0.3539.0 (Revision:588235) Note: Issue is Mac OS specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS).
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72a1b530551a7f03144ffe660f2ee7d0fd2feaec commit 72a1b530551a7f03144ffe660f2ee7d0fd2feaec Author: Ben Wells <benwells@chromium.org> Date: Wed Sep 05 22:10:15 2018 Fix broken chrome://apps context menu for Mac Any platform that didn't support the App Info menu item would not show the correct menu due to a bug in the menu construction logic. Bug: 880257 Change-Id: I26501b4968f65b089d9a17e25b036ccc1178d0d0 Reviewed-on: https://chromium-review.googlesource.com/1205921 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#589024} [modify] https://crrev.com/72a1b530551a7f03144ffe660f2ee7d0fd2feaec/chrome/browser/resources/ntp4/apps_page.js
,
Sep 5
Updating milestones as the cl that caused the bug was merged into M70.
,
Sep 5
(will request merge after testing in canary)
,
Sep 6
Update : Rechecked the above issue on Mac OS X(10.12.6,10.13.1,10.13.6) with latest Canary Chrome version : 71.0.3544.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..!!
,
Sep 7
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01121fed1b89c686da0606f747ad808496d4d9e1 commit 01121fed1b89c686da0606f747ad808496d4d9e1 Author: Ben Wells <benwells@chromium.org> Date: Mon Sep 10 08:27:02 2018 Fix broken chrome://apps context menu for Mac Any platform that didn't support the App Info menu item would not show the correct menu due to a bug in the menu construction logic. TBR=benwells@chromium.org (cherry picked from commit 72a1b530551a7f03144ffe660f2ee7d0fd2feaec) Bug: 880257 Change-Id: I26501b4968f65b089d9a17e25b036ccc1178d0d0 Reviewed-on: https://chromium-review.googlesource.com/1205921 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589024} Reviewed-on: https://chromium-review.googlesource.com/1214905 Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#202} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/01121fed1b89c686da0606f747ad808496d4d9e1/chrome/browser/resources/ntp4/apps_page.js
,
Sep 12
Update : Rechecked the above issue on Mac OS X(10.12.6,10.13.1,10.13.6,10.14) with Chrome version : 70.0.3538.16.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Sep 4Owner: benwells@chromium.org
Status: Assigned (was: Unconfirmed)