New issue
Advanced search Search tips

Issue 880245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow



Sign in to add a comment

VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow is Flaky

Project Member Reported by Findit, Sep 4

Issue description

Cc: hua...@chromium.org
Owner: goog...@chromium.org
From https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7640

Other Keyboard-related tests might be affected as well (linux-chromeos-dbg).

Going to revert the CL.


Thanks for the quick fix, working on it now.
Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a

commit b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a
Author: Leo Zhang <googleo@chromium.org>
Date: Mon Sep 10 06:27:27 2018

Add a ChromeOS feature for IME service.

The feature was previously created under the IME service, I refactored
it by moving it to ChromeOS features for a simple structure and
passing it to the IME extension. This feature is used for switching
whether the IME component extension is able to connect to IME service.

Bug: 837156, 880245 
Change-Id: I832b60e1bcc90708771a935dc9f3172067eb8544
Reviewed-on: https://chromium-review.googlesource.com/1209131
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589835}
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chrome/browser/extensions/chrome_extensions_interface_registration.cc
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chromeos/chromeos_features.cc
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chromeos/chromeos_features.h
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/chromeos/services/ime/public/cpp/BUILD.gn
[delete] https://crrev.com/4ecb0a89f46ad7412ae19cc5d7417c23d8b61fab/chromeos/services/ime/public/cpp/features.cc
[delete] https://crrev.com/4ecb0a89f46ad7412ae19cc5d7417c23d8b61fab/chromeos/services/ime/public/cpp/features.h
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/ui/keyboard/BUILD.gn
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/ui/keyboard/DEPS
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/b5ad005bbf38388596ac7f93bcb3c4d6aae41d8a/ui/keyboard/keyboard_util.h

Status: Fixed (was: Available)

Sign in to add a comment