Issue metadata
Sign in to add a comment
|
Regression : Immediate effect is not seen at volume slider(in Uber Tray) after connecting and removing Earphones/Headphones |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.0/11031.0.0 dev channel Candy,Peppy,Reks OS: Chrome What steps will reproduce the problem? 1)Recover Build -> Now in OOBE screen click on Uber Tray ->Connect Earphones/Headphones and observe Headphone icon on the volume slider is not seen and now close Uber Tray and again click on Uber Tray -> Now observe Headphone icon on the volume slider (2)Now remove Earphones/Headphones and observe volume slider i.e. unnecessary space is seen -> close Uber Tray and again click on Uber Tray and now no space is seen (Please refer Video and Screenshot) Expected: Immediate effect should be seen at volume slider(in Uber Tray) after connecting and removing Earphones/Headphones Actual: Instead Immediate effect is not seen at volume slider after connecting and removing Earphones/Headphones This is Regression Issue as same is working fine on M-69
,
Sep 5
,
Sep 10
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60855f391e695c8b46a3e07d94ecfcfc2fc198e6 commit 60855f391e695c8b46a3e07d94ecfcfc2fc198e6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Sep 11 01:01:46 2018 Unified: Relayout audio settings button on change In order to show audio settings button on headphone connectivity change, we should relayout the slider view when visibility is changed. TEST=manual BUG= 880237 Change-Id: I966ee7082987ddbefb83a434657c5b733570ca94 Reviewed-on: https://chromium-review.googlesource.com/1215509 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#590151} [modify] https://crrev.com/60855f391e695c8b46a3e07d94ecfcfc2fc198e6/ash/system/audio/unified_volume_view.cc
,
Sep 11
,
Sep 11
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 11
,
Sep 12
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbe82ca4d69993bb4e3ad42fdf560aef086d347a commit fbe82ca4d69993bb4e3ad42fdf560aef086d347a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Sep 13 03:54:08 2018 Unified: Relayout audio settings button on change In order to show audio settings button on headphone connectivity change, we should relayout the slider view when visibility is changed. TEST=manual BUG= 880237 Change-Id: I966ee7082987ddbefb83a434657c5b733570ca94 Reviewed-on: https://chromium-review.googlesource.com/1215509 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590151}(cherry picked from commit 60855f391e695c8b46a3e07d94ecfcfc2fc198e6) Reviewed-on: https://chromium-review.googlesource.com/1223530 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#359} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/fbe82ca4d69993bb4e3ad42fdf560aef086d347a/ash/system/audio/unified_volume_view.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Sep 411.9 MB
11.9 MB View Download