Non-Regression: After clicking on Change in lock screen, nothing happens in signed in screen |
|||||||
Issue descriptionChrome Version: 70.0.3538.0/11031.0.0 dev channel Candy,Peppy,Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Have some notification and lock the screen (2)Click on ubertray and then on Change button and sign-in to user >> Observe nothing happens Actual: After clicking on Change in lock screen, nothing happens in signed in screen Expected: As the message says 'Unlock device to perform the notification action', after unlocking either notification should be seen or else 'change' button should not be seen in lock screen This is a Non-Regression issue seen from 70.0.3538.0/11030.0.0 dev
,
Sep 5
Let me disable this on M70.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0060319de53ebdd5b9514e5cfa435b3bede27323 commit 0060319de53ebdd5b9514e5cfa435b3bede27323 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Wed Sep 05 10:18:17 2018 Disable lock screen notification by default The feature is not launched on M70. This CL should be merged to M70 branch as well. R: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: I2d8f3dbe97bcd0c8d28cfe775e2c86dd1e169d11 Reviewed-on: https://chromium-review.googlesource.com/1206551 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#588815} [modify] https://crrev.com/0060319de53ebdd5b9514e5cfa435b3bede27323/ash/public/cpp/ash_features.cc
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af8b1990a2104621f03d78d16d4ab18d8958829e commit af8b1990a2104621f03d78d16d4ab18d8958829e Author: Samuel Huang <huangs@chromium.org> Date: Wed Sep 05 21:23:29 2018 Revert "Disable lock screen notification by default" This reverts commit 0060319de53ebdd5b9514e5cfa435b3bede27323. Reason for revert: http://crbug.com/881042 : exo_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) : Speculative revert to see if it fixes the memory leak (also in other tests). Original change's description: > Disable lock screen notification by default > > The feature is not launched on M70. This CL should be merged to M70 branch as well. > > R: yamaguchi@chromium.org > TBR: oshima@chromium.org > Bug: 880227 > Change-Id: I2d8f3dbe97bcd0c8d28cfe775e2c86dd1e169d11 > Reviewed-on: https://chromium-review.googlesource.com/1206551 > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588815} TBR=yoshiki@chromium.org,oshima@chromium.org,yamaguchi@chromium.org Change-Id: I8fe6b9ca4fbf195e229e44d5a85e1c5589733e8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880227 Reviewed-on: https://chromium-review.googlesource.com/1208136 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589003} [modify] https://crrev.com/af8b1990a2104621f03d78d16d4ab18d8958829e/ash/public/cpp/ash_features.cc
,
Sep 6
,
Sep 6
Ah, CL is reverted. Let me investigate before reland and margerequest.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/379144a498035bbfb51cb00671e6408f152193c5 commit 379144a498035bbfb51cb00671e6408f152193c5 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Fri Sep 07 10:32:39 2018 Disable lock screen notification by default This is reland of crrev.com/c/1206551 after fixing the memory leak (crrev.com/c/1208694). The diff is completely same as the previous CL. The previous CL had been reverted due to the ASAN failure (see. crbug.com/880227 ). [Original description] The feature is not launched on M70. This CL should be merged to M70 branch as well. TBR: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: Id0ca9b5ee488130d7fb0c414b4a9522117d462dd Reviewed-on: https://chromium-review.googlesource.com/1212902 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589485} [modify] https://crrev.com/379144a498035bbfb51cb00671e6408f152193c5/ash/public/cpp/ash_features.cc
,
Sep 7
,
Sep 7
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e346bd39a0c938a6bc36958835a4cb42621b68 commit 68e346bd39a0c938a6bc36958835a4cb42621b68 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Mon Sep 10 05:14:48 2018 Fix memory leak whthout lock screen notification on NotificationHiddenView If the lock screen notification is disabled, NotificationHiddenView had a leak. This CL fixes that. TBR=yoshiki@chromium.org (cherry picked from commit bed6b8831dec04d741e87bc02c1d180a17cc2c9a) Bug: 880227 Change-Id: I0ddb2a37777849c44ac19e4398ea88369fcb4a08 Reviewed-on: https://chromium-review.googlesource.com/1208694 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589113} Reviewed-on: https://chromium-review.googlesource.com/1215431 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#200} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/68e346bd39a0c938a6bc36958835a4cb42621b68/ash/system/unified/notification_hidden_view.cc
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afcf5c67a52325872abd578fee81657cf0835662 commit afcf5c67a52325872abd578fee81657cf0835662 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Mon Sep 10 05:30:47 2018 Disable lock screen notification by default The feature is not launched on M70. This CL should be merged to M70 branch as well. TBR=yoshiki@chromium.org (cherry picked from commit 0060319de53ebdd5b9514e5cfa435b3bede27323) R: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: I2d8f3dbe97bcd0c8d28cfe775e2c86dd1e169d11 Reviewed-on: https://chromium-review.googlesource.com/1206551 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588815} Reviewed-on: https://chromium-review.googlesource.com/1215369 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#201} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/afcf5c67a52325872abd578fee81657cf0835662/ash/public/cpp/ash_features.cc
,
Sep 10
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yamaguchi@chromium.org
, Sep 4