Issue metadata
Sign in to add a comment
|
Regression: Unnecessary movement is seen when clicking on 'Remove this user' in sign-out screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.0/11031.0.0 dev channel Candy,Peppy,Reks OS: Chrome OS Pre-condition: Add 2 user accounts What steps will reproduce the problem? (1)In Sign-out screen>> Click on 'Remove this user' drop down and then on 'Remove this user', observe unnecessary movement is seen Actual: Unnecessary movement is seen when clicking on 'Remove this user' Expected: No such issue should be seen This is a Regression issue as same is working fine in 70.0.3532.0/11014.0.0 dev Attaching screencasts for reference..
,
Sep 10
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593f022c3388819e053d6426dda7f4d84d62145d commit 593f022c3388819e053d6426dda7f4d84d62145d Author: Quan Nguyen <qnnguyen@chromium.org> Date: Mon Sep 10 22:15:12 2018 cros: Don't reposition login bubbles vertically. Previously we prevented the login bubbles from overlapping into the shelf. This had some annoying side effects like obscuring the password field. This CL removes that part of the widget repositioning logic. A future CL will address the potential case of login bubbles going off screen on the bottom. Need to clarify the correct UX for this case. Bug: 880224 , 875787 Change-Id: Iea42cd612e9b0c57516fdc9681843182fa8d268b Reviewed-on: https://chromium-review.googlesource.com/1217742 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590087} [modify] https://crrev.com/593f022c3388819e053d6426dda7f4d84d62145d/ash/login/ui/login_bubble.cc [modify] https://crrev.com/593f022c3388819e053d6426dda7f4d84d62145d/ash/login/ui/login_bubble.h
,
Sep 10
,
Sep 11
,
Sep 12
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1736d324df7607dfb737daeff789ff7fc2c8b687 commit 1736d324df7607dfb737daeff789ff7fc2c8b687 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Wed Sep 12 22:46:55 2018 cros: Don't reposition login bubbles vertically. Previously we prevented the login bubbles from overlapping into the shelf. This had some annoying side effects like obscuring the password field. This CL removes that part of the widget repositioning logic. A future CL will address the potential case of login bubbles going off screen on the bottom. Need to clarify the correct UX for this case. Bug: 880224 , 875787 Change-Id: Iea42cd612e9b0c57516fdc9681843182fa8d268b Reviewed-on: https://chromium-review.googlesource.com/1217742 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#590087}(cherry picked from commit 593f022c3388819e053d6426dda7f4d84d62145d) Reviewed-on: https://chromium-review.googlesource.com/1222747 Cr-Commit-Position: refs/branch-heads/3538@{#346} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/1736d324df7607dfb737daeff789ff7fc2c8b687/ash/login/ui/login_bubble.cc [modify] https://crrev.com/1736d324df7607dfb737daeff789ff7fc2c8b687/ash/login/ui/login_bubble.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jdufault@chromium.org
, Sep 10Labels: -Pri-1 -M-70 M-71 Pri-2
Status: Available (was: Untriaged)