Issue metadata
Sign in to add a comment
|
Regression: Unnecessary extra padding is seen when changing shelf from left to right or from right to left |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.0/11031.0.0 dev channel Candy,Peppy,Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Chnage shelf position to left and then change it to right observe unnecessary extra padding Actual: Unnecessary extra padding is seen when changing shelf from left to right or from right to left Expected: No such issue should be seen This is a Regression issue as same is working fine in 70.0.3532.0/11014.0.0 dev Attaching screencasts for reference..
,
Sep 4
,
Sep 4
,
Sep 4
,
Sep 4
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 4
,
Sep 5
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/659ba835aaa4edd4a66ce3d49af82b6917c6042a commit 659ba835aaa4edd4a66ce3d49af82b6917c6042a Author: Manu Cornet <manucornet@chromium.org> Date: Tue Sep 04 22:24:11 2018 CrOS Shelf: let ShelfWidget react to shelf alignment changes This fixes a bug where the shelf's opaque background would not get updated when the shelf's alignment changed but didn't change bounds (i.e. from left to right and vice versa). Bug: 880221 Change-Id: Iafc6eb013ec598177a555317e36adb8cce2341f0 Reviewed-on: https://chromium-review.googlesource.com/1204972 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588669} [modify] https://crrev.com/659ba835aaa4edd4a66ce3d49af82b6917c6042a/ash/shelf/shelf_widget.cc
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a150e2c5cc57a236058dd158b60c19e367c4078b commit a150e2c5cc57a236058dd158b60c19e367c4078b Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Sep 07 21:18:32 2018 CrOS Shelf: let ShelfWidget react to shelf alignment changes This fixes a bug where the shelf's opaque background would not get updated when the shelf's alignment changed but didn't change bounds (i.e. from left to right and vice versa). TBR=manucornet@chromium.org (cherry picked from commit 659ba835aaa4edd4a66ce3d49af82b6917c6042a) Bug: 880221 Change-Id: Iafc6eb013ec598177a555317e36adb8cce2341f0 Reviewed-on: https://chromium-review.googlesource.com/1204972 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588669} Reviewed-on: https://chromium-review.googlesource.com/1213663 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#168} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/a150e2c5cc57a236058dd158b60c19e367c4078b/ash/shelf/shelf_widget.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Sep 4