New issue
Advanced search Search tips

Issue 880212 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 7
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 812168



Sign in to add a comment

Ensure SiteIsolated code caches work with Inline code caching.

Project Member Reported by mythria@chromium.org, Sep 4 
Currently site isolated code caches only fetch script resources. We should extend this to also work for inline scripts.

Comment 1 by mythria@chromium.org, Sep 4

Blocking: 812168
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17b2cd307724a80cb8a39a1f4543c71c08d14af

commit f17b2cd307724a80cb8a39a1f4543c71c08d14af
Author: Mythri Alle <mythria@chromium.org>
Date: Thu Sep 06 11:40:21 2018

Update ResourceLoader to also fetch cached code for inline scripts

V8 also stores code caches for inline scripts in the html resources.
This cl updates ResourceLoader to fetch cached code for inline scripts
in MainResources.

Bug:  chromium:880212 , chromium:812168
Change-Id: I822453b52897aac292444df20e50937d8198064d
Reviewed-on: https://chromium-review.googlesource.com/1208391
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589137}
[modify] https://crrev.com/f17b2cd307724a80cb8a39a1f4543c71c08d14af/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Comment 3 by mythria@chromium.org, Sep 7

Status: Fixed (was: Available)
This turned out to  be much simpler than what I anticipated. Even for main frame navigations, the request is processed by ResourceLoader. So, just fetching code caches in ResourceLoader works for all inline scripts.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec94596ab8bf80c070f0472a18420ec77fe9102

commit 9ec94596ab8bf80c070f0472a18420ec77fe9102
Author: Mythri Alle <mythria@chromium.org>
Date: Fri Sep 07 22:16:28 2018

Revert "Update ResourceLoader to also fetch cached code for inline scripts"

This reverts commit f17b2cd307724a80cb8a39a1f4543c71c08d14af.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update ResourceLoader to also fetch cached code for inline scripts
> 
> V8 also stores code caches for inline scripts in the html resources.
> This cl updates ResourceLoader to fetch cached code for inline scripts
> in MainResources.
> 
> Bug:  chromium:880212 , chromium:812168
> Change-Id: I822453b52897aac292444df20e50937d8198064d
> Reviewed-on: https://chromium-review.googlesource.com/1208391
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589137}

TBR=kinuko@chromium.org,mythria@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:880212 , chromium:812168
Change-Id: I4e24815c37378a86e334c8fe88129dff39ee87dd
Reviewed-on: https://chromium-review.googlesource.com/1213094
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589684}
[modify] https://crrev.com/9ec94596ab8bf80c070f0472a18420ec77fe9102/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410fdcf2ab611bddfeb6ec3702c39faaa9249dad

commit 410fdcf2ab611bddfeb6ec3702c39faaa9249dad
Author: Mythri Alle <mythria@chromium.org>
Date: Tue Sep 11 05:56:02 2018

Reland "Update ResourceLoader to also fetch cached code for inline scripts"

This is a reland of f17b2cd307724a80cb8a39a1f4543c71c08d14af

Original change's description:
> Update ResourceLoader to also fetch cached code for inline scripts
> 
> V8 also stores code caches for inline scripts in the html resources.
> This cl updates ResourceLoader to fetch cached code for inline scripts
> in MainResources.
> 
> Bug:  chromium:880212 , chromium:812168
> Change-Id: I822453b52897aac292444df20e50937d8198064d
> Reviewed-on: https://chromium-review.googlesource.com/1208391
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589137}

Bug:  chromium:880212 , chromium:812168
Change-Id: I5d0d38bf89de68d6fe88324a42742b2dfac3be96
Reviewed-on: https://chromium-review.googlesource.com/1215326
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590213}
[modify] https://crrev.com/410fdcf2ab611bddfeb6ec3702c39faaa9249dad/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
►

Sign in to add a comment